Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Address fifth part of 451: Implement Key.complete_key for auto_id on partial keys. #461

Merged
merged 2 commits into from
Dec 31, 2014
Merged

Address fifth part of 451: Implement Key.complete_key for auto_id on partial keys. #461

merged 2 commits into from
Dec 31, 2014

Conversation

dhermes
Copy link
Contributor

@dhermes dhermes commented Dec 23, 2014

Addresses fifth part of #451.

NOTE: This has #460 as a diffbase.

@dhermes dhermes mentioned this pull request Dec 23, 2014
Closed
10 tasks
@coveralls
Copy link

Coverage Status

Coverage remained the same when pulling 64ab5ee on dhermes:fix-451-part5 into b343acf on GoogleCloudPlatform:master.

@dhermes dhermes mentioned this pull request Dec 23, 2014
Merged
@tseaver
Copy link
Contributor

tseaver commented Dec 30, 2014

64ab5ee Maybe finalize as a name, instead of complete_key? Kind of fits with is_partial, too.

LGTM either way.

@dhermes
Copy link
Contributor Author

dhermes commented Dec 30, 2014

I worry that would indicate that it wasn't already final, which it sort of is by being immutable.

@coveralls
Copy link

Coverage Status

Coverage remained the same when pulling 1442143 on dhermes:fix-451-part5 into 8cb41f6 on GoogleCloudPlatform:master.

@tseaver
Copy link
Contributor

tseaver commented Dec 31, 2014

Do we need to change is_final then?

Other than that, LGTM.

@dhermes
Copy link
Contributor Author

dhermes commented Dec 31, 2014

Does is_final exist? Here in complete_key, complete is the verb, not the adjective. But the ambiguity means it may be better to find another word.

@coveralls
Copy link

Coverage Status

Coverage remained the same when pulling 33d546d on dhermes:fix-451-part5 into 74e6c16 on GoogleCloudPlatform:master.

@dhermes
Copy link
Contributor Author

dhermes commented Dec 31, 2014

Since it is a method on Key, the _key is a bit redunant. @tseaver WDYT about Key.make_complete?

@tseaver
Copy link
Contributor

tseaver commented Dec 31, 2014

I was misremembering 'is_partial' as 'is_final'. How about 'completed_key', since it returns a new instance (if needed).

@tseaver
Copy link
Contributor

tseaver commented Dec 31, 2014

Or even 'complete_from_pb'?

@dhermes
Copy link
Contributor Author

dhermes commented Dec 31, 2014

completed SGTM. It's not being completed from a pb. Will rewrite and ping you after new commit.

@dhermes
Copy link
Contributor Author

dhermes commented Dec 31, 2014

1df085e pushed

tseaver added a commit that referenced this pull request Dec 31, 2014
@tseaver
Merge pull request #461 from dhermes/fix-451-part5
f0e26b8 
Address fifth part of 451: Implement Key.complete_key for auto_id on partial keys.
@tseaver tseaver merged commit f0e26b8 into googleapis:master Dec 31, 2014
@coveralls
Copy link

Coverage Status

Coverage remained the same when pulling 1df085e on dhermes:fix-451-part5 into 74e6c16 on GoogleCloudPlatform:master.

@dhermes dhermes deleted the fix-451-part5 branch December 31, 2014 21:31
@dhermes dhermes added the api: datastore Issues related to the Datastore API. label Dec 31, 2015
atulep pushed a commit that referenced this pull request Apr 3, 2023
@release-please
chore(main): release 2.17.0 (#461)
59f30ef 
Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
atulep pushed a commit that referenced this pull request Apr 6, 2023
@release-please
chore(main): release 2.17.0 (#461)
ef727b9 
Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
atulep pushed a commit that referenced this pull request Apr 6, 2023
@release-please
chore(main): release 2.17.0 (#461)
2d16f4f 
Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
atulep pushed a commit that referenced this pull request Apr 18, 2023
@release-please
chore(main): release 2.17.0 (#461)
7785e49 
Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
parthea pushed a commit that referenced this pull request Jun 4, 2023
@gcf-owl-bot
chore: Update gapic-generator-python to v1.8.4 (#461)
a33302e 
* chore: Update gapic-generator-python to v1.8.4

PiperOrigin-RevId: 507808936

Source-Link: googleapis/googleapis@64cf849

Source-Link: googleapis/googleapis-gen@53c48ca
Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiNTNjNDhjYWMxNTNkM2IzN2YzZDJjMmRlYzQ4MzBjZmQ5MWVjNDE1MyJ9

* 🦉 Updates from OwlBot post-processor

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

---------

Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
parthea pushed a commit that referenced this pull request Sep 22, 2023
@renovate-bot
chore(deps): update dependency google-auth to v2.11.0 (#461)
9e37296
parthea pushed a commit that referenced this pull request Sep 22, 2023
@gcf-owl-bot
chore(python): drop flake8-import-order in samples noxfile [autoappro…
80b4089 
…ve] (#461)

Source-Link: https://togithub.com/googleapis/synthtool/commit/6ed3a831cb9ff69ef8a504c353e098ec0192ad93
Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:3abfa0f1886adaf0b83f07cb117b24a639ea1cb9cffe56d43280b977033563eb
parthea added a commit that referenced this pull request Oct 21, 2023
@renovate-bot @gcf-owl-bot @parthea
chore(deps): update all dependencies (#461)
3a0b9ae 
* chore(deps): update all dependencies

* 🦉 Updates from OwlBot post-processor

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

* revert

Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
Co-authored-by: Anthonios Partheniou <partheniou@google.com>
parthea added a commit that referenced this pull request Oct 21, 2023
@parthea
fix(deps): require google-api-core>=1.32.0,>=2.8.0 (#461)
eda63e3 
* fix(deps): require google-api-core>=1.32.0,>=2.8.0

* chore: update constraints
parthea added a commit that referenced this pull request Oct 21, 2023
@gcf-owl-bot @parthea
docs: fix minor docstring formatting (#461)
0d9859c 
* chore: update to gapic-generator-python 1.5.0

feat: add support for `google.cloud.<api>.__version__`
PiperOrigin-RevId: 484665853

Source-Link: googleapis/googleapis@8eb249a

Source-Link: googleapis/googleapis-gen@c8aa327
Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiYzhhYTMyN2I1ZjQ3ODg2NWZjM2ZkOTFlM2MyNzY4ZTU0ZTI2YWQ0NCJ9

* 🦉 Updates from OwlBot post-processor

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

* update version in gapic_version.py

* chore: Update to gapic-generator-python 1.6.0

feat(python): Add typing to proto.Message based class attributes

feat(python): Snippetgen handling of repeated enum field

PiperOrigin-RevId: 487326846

Source-Link: googleapis/googleapis@da380c7

Source-Link: googleapis/googleapis-gen@61ef576
Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiNjFlZjU3NjJlZTY3MzFhMGNiYmZlYTIyZmQwZWVjZWU1MWFiMWM4ZSJ9

* 🦉 Updates from OwlBot post-processor

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

* feat: new APIs added to reflect updates to the filestore service

- Add ENTERPRISE Tier
- Add snapshot APIs: RevertInstance, ListSnapshots, CreateSnapshot, DeleteSnapshot, UpdateSnapshot
- Add multi-share APIs: ListShares, GetShare, CreateShare, DeleteShare, UpdateShare
- Add ConnectMode to NetworkConfig (for Private Service Access support)
- New status codes (SUSPENDED/SUSPENDING, REVERTING/RESUMING)
- Add SuspensionReason (for KMS related suspension)
- Add new fields to Instance information: max_capacity_gb, capacity_step_size_gb, max_share_count, capacity_gb, multi_share_enabled

PiperOrigin-RevId: 487492758

Source-Link: googleapis/googleapis@5be5981

Source-Link: googleapis/googleapis-gen@ab0e217
Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiYWIwZTIxN2Y1NjBjYzJjMWFmYzExNDQxYzJlYWI2YjY5NTBlZmQyYiJ9

* 🦉 Updates from OwlBot post-processor

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

* chore: Update gapic-generator-python to v1.6.1

PiperOrigin-RevId: 488036204

Source-Link: googleapis/googleapis@08f275f

Source-Link: googleapis/googleapis-gen@555c094
Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiNTU1YzA5NDVlNjA2NDllMzg3MzlhZTY0YmM0NTcxOWNkZjcyMTc4ZiJ9

* 🦉 Updates from OwlBot post-processor

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

* fix(deps): Require google-api-core >=1.34.0, >=2.11.0

fix: Drop usage of pkg_resources

fix: Fix timeout default values

docs(samples): Snippetgen should call await on the operation coroutine before calling result

PiperOrigin-RevId: 493260409

Source-Link: googleapis/googleapis@fea4387

Source-Link: googleapis/googleapis-gen@387b734
Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiMzg3YjczNDRjNzUyOWVlNDRiZTg0ZTYxM2IxOWE4MjA1MDhjNjEyYiJ9

* 🦉 Updates from OwlBot post-processor

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

* docs: fix minor docstring formatting

PiperOrigin-RevId: 493589316

Source-Link: googleapis/googleapis@02e3850

Source-Link: googleapis/googleapis-gen@ab49dcf
Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiYWI0OWRjZjU2MDhlNzE1OWQwN2Y1M2JkODg4Zjk3ZDIwOTIwMzVlNyJ9

* 🦉 Updates from OwlBot post-processor

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

* use templated owlbot.py and autogenerated setup.py

* configure release please to use manifest

Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
Co-authored-by: Anthonios Partheniou <partheniou@google.com>
parthea added a commit that referenced this pull request Oct 21, 2023
@renovate-bot @gcf-owl-bot @parthea
chore(deps): update all dependencies (#461)
83efe79 
* chore(deps): update all dependencies

* 🦉 Updates from OwlBot post-processor

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

* revert

Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
Co-authored-by: Anthonios Partheniou <partheniou@google.com>
parthea added a commit that referenced this pull request Oct 21, 2023
@gcf-owl-bot @parthea
feat: Add support for python 3.11 (#461)
22c4179 
* feat: Add support for python 3.11

chore: Update gapic-generator-python to v1.8.0
PiperOrigin-RevId: 500768693

Source-Link: googleapis/googleapis@190b612

Source-Link: googleapis/googleapis-gen@7bf29a4
Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiN2JmMjlhNDE0YjllY2FjMzE3MGYwYjY1YmRjMmE5NTcwNWMwZWYxYSJ9

* 🦉 Updates from OwlBot post-processor

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

* require proto-plus 1.22.2 for python 3.11

Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
Co-authored-by: Anthonios Partheniou <partheniou@google.com>
parthea pushed a commit that referenced this pull request Oct 22, 2023
@release-please
chore(main): release 2.17.0 (#461)
b721305 
Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
api: datastore Issues related to the Datastore API.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dhermes @coveralls @tseaver