Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Spanner: Session to database transaction-usage #4510

Merged
merged 1 commit into from
Dec 4, 2017
Merged

Spanner: Session to database transaction-usage #4510

merged 1 commit into from
Dec 4, 2017

Conversation

chemelnucfin
Copy link
Contributor

No description provided.

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Dec 1, 2017
@dhermes dhermes added the api: spanner Issues related to the Spanner API. label Dec 1, 2017
@chemelnucfin chemelnucfin reopened this Dec 4, 2017
@chemelnucfin
Copy link
Contributor Author

Must have closed the wrong one.

tseaver
tseaver approved these changes Dec 4, 2017
View reviewed changes
Copy link
Contributor

@tseaver tseaver left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We might want to ditch usage docs for individual transactions altogether: the Spanner team would prefer that everyone use database.run_in_transation, I believe.

@chemelnucfin
Copy link
Contributor Author

So do I still merge this or just delete the file?

@tseaver
Copy link
Contributor

tseaver commented Dec 4, 2017

Merge it. I was just speculating that the whole chapter might be unwanted (by the Spanner team).

@chemelnucfin chemelnucfin merged commit 53944d5 into googleapis:master Dec 4, 2017
alixhami added a commit that referenced this pull request Dec 4, 2017
@alixhami
Revert "Spanner: Session to database transaction-usage (#4510)"
b5b473d 
This reverts commit 53944d5.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tseaver tseaver tseaver approved these changes

@lukesneeringer lukesneeringer Awaiting requested review from lukesneeringer

Assignees
No one assigned
Labels
api: spanner Issues related to the Spanner API. cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@chemelnucfin @tseaver @dhermes @googlebot