Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Spanner: Test return empty array struct #4449

Merged
merged 4 commits into from
Oct 30, 2018
Merged

Spanner: Test return empty array struct #4449

merged 4 commits into from
Oct 30, 2018

Conversation

chemelnucfin
Copy link
Contributor

No description provided.

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Nov 25, 2017
@chemelnucfin chemelnucfin changed the title Spanner: Test Return Empty Array Struct Spanner: Test return empty array struct Nov 27, 2017
@chemelnucfin chemelnucfin added the api: spanner Issues related to the Spanner API. label Nov 27, 2017
@tseaver
Copy link
Contributor

tseaver commented Dec 4, 2017

No system test required (marked "unit").

@tseaver tseaver closed this Dec 4, 2017
@tseaver tseaver reopened this Oct 25, 2018
@tseaver
Copy link
Contributor

tseaver commented Oct 25, 2018

No longer marked "unit" in the current spreadsheet. :(

@tseaver tseaver requested a review from crwilcox as a code owner October 25, 2018 19:46
@tseaver tseaver added testing kokoro:force-run Add this label to force Kokoro to re-run the tests. labels Oct 25, 2018
@kokoro-team kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Oct 25, 2018
@googlebot
Copy link

So there's good news and bad news.

👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there.

😕 The bad news is that it appears that one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that here in the pull request.

Note to project maintainer: This is a terminal state, meaning the cla/google commit status will not change from this state. It's up to you to confirm consent of all the commit author(s), set the cla label to yes (if enabled on your project), and then merge this pull request when appropriate.

@googlebot googlebot added cla: no This human has *not* signed the Contributor License Agreement. and removed cla: yes This human has signed the Contributor License Agreement. labels Oct 25, 2018
@tseaver tseaver added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Oct 25, 2018
@kokoro-team kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Oct 25, 2018
@tseaver tseaver added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Oct 25, 2018
@kokoro-team kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Oct 25, 2018
@tseaver
Copy link
Contributor

tseaver commented Oct 25, 2018

@crwilcox If you can flip the CLA flag, I think this is ready to merge.

@chemelnucfin
Copy link
Contributor Author

chemelnucfin commented Oct 26, 2018 via email

@tseaver
Copy link
Contributor

tseaver commented Oct 29, 2018

@crwilcox, @theacodes Can one of you please flip the CLA flag?

@crwilcox crwilcox added the cla: yes This human has signed the Contributor License Agreement. label Oct 29, 2018
@googlebot
Copy link

A Googler has manually verified that the CLAs look good.

(Googler, please make sure the reason for overriding the CLA status is clearly documented in these comments.)

@googlebot googlebot removed the cla: no This human has *not* signed the Contributor License Agreement. label Oct 29, 2018
@tseaver tseaver merged commit 7b41d69 into googleapis:master Oct 30, 2018
@chemelnucfin chemelnucfin deleted the spanner_empty_struct branch October 31, 2018 04:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tseaver tseaver tseaver approved these changes

@lukesneeringer lukesneeringer Awaiting requested review from lukesneeringer

@crwilcox crwilcox Awaiting requested review from crwilcox

Assignees
No one assigned
Labels
api: spanner Issues related to the Spanner API. cla: yes This human has signed the Contributor License Agreement. testing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@chemelnucfin @tseaver @googlebot @crwilcox @kokoro-team