bigquery: support external table definitions for query jobs #4191
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tswast
approved these changes
Oct 16, 2017
| @@ -1469,6 +1463,12 @@ def from_api_repr(cls, resource): | |||
| https://g.co/cloud/bigquery/docs/reference/rest/v2/jobs#configuration.query.writeDisposition | |||
| """ | |||
|
|
|||
| table_definitions = _TypedApiResourceProperty( | |||
| 'table_definitions', 'tableDefinitions', dict) | |||
| """See | |||
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
Also, set ExternalConfig.options based on source_format, and make read-only. Also, change from_api_repr functions in external_config.py so that they don't modify their resource argument. This simplifies tests.
tswast
pushed a commit
that referenced
this pull request
Oct 16, 2017
Also, set ExternalConfig.options based on source_format, and make read-only. Also, change from_api_repr functions in external_config.py so that they don't modify their resource argument. This simplifies tests.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also, set ExternalConfig.options based on source_format, and
make read-only.
Also, change from_api_repr functions in external_config.py so that
they don't modify their resource argument. This simplifies tests.