Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bigquery: modify LoadJob #4103

Merged
merged 2 commits into from
Oct 4, 2017
Merged

bigquery: modify LoadJob #4103

merged 2 commits into from
Oct 4, 2017

Conversation

jba
Copy link
Contributor

@jba jba commented Oct 2, 2017

This PR handles loading from GCS. Loading from a local file will be done separately.

@jba
bigquery: modify LoadJob
a90f7ea 
This PR handles loading from GCS. Loading from a local
file will be done separately.
@jba jba requested a review from lukesneeringer as a code owner October 2, 2017 21:44
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Oct 2, 2017
@jba jba requested review from tseaver, tswast and alixhami October 2, 2017 21:45
tswast
tswast requested changes Oct 2, 2017
View reviewed changes
bigquery/google/cloud/bigquery/client.py Outdated
@@ -17,6 +17,7 @@
from __future__ import absolute_import

import collections
import six

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

bigquery/google/cloud/bigquery/client.py Outdated
@@ -490,26 +491,37 @@ def list_jobs(self, max_results=None, page_token=None, all_users=None,
max_results=max_results,
extra_params=extra_params)

def load_table_from_storage(self, job_id, destination, *source_uris):
def load_table_from_storage(self, destination, source_uris,

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

bigquery/google/cloud/bigquery/job.py

def __init__(self):
self._properties = {}
self._schema = ()

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

bigquery/google/cloud/bigquery/job.py Outdated
config = copy.deepcopy(self._properties)
if len(self.schema) > 0:
config['schema'] = {'fields': _build_schema_resource(self.schema)}
# TODO(jba): add a comment explaining why skipLeadingRows is a string.

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

tswast
tswast approved these changes Oct 4, 2017
View reviewed changes
bigquery/google/cloud/bigquery/client.py Outdated
@@ -490,26 +492,37 @@ def list_jobs(self, max_results=None, page_token=None, all_users=None,
max_results=max_results,
extra_params=extra_params)

def load_table_from_storage(self, job_id, destination, *source_uris):
def load_table_from_storage(self, source_uris, destination,
job_id=None, job_config=None):
"""Construct a job for loading data into a table from CloudStorage.

This comment was marked as spam.

Sign in to view

@jba jba merged commit 01fc4f4 into googleapis:bigquery-b2 Oct 4, 2017
tswast pushed a commit that referenced this pull request Oct 12, 2017
@jba @tswast
bigquery: modify LoadJob (#4103)
f90bbb7 
This PR handles loading from GCS. Loading from a local
file will be done separately.
tswast pushed a commit that referenced this pull request Oct 16, 2017
@jba @tswast
bigquery: modify LoadJob (#4103)
b649544 
This PR handles loading from GCS. Loading from a local
file will be done separately.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dhermes dhermes dhermes left review comments

@tswast tswast tswast approved these changes

@lukesneeringer lukesneeringer Awaiting requested review from lukesneeringer

@tseaver tseaver Awaiting requested review from tseaver

@alixhami alixhami Awaiting requested review from alixhami

Assignees
No one assigned
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jba @tswast @dhermes @googlebot