Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BigQuery: Adds client.get_table() and removes table.reload() #4004

Merged
merged 4 commits into from
Sep 20, 2017
Merged

BigQuery: Adds client.get_table() and removes table.reload() #4004

merged 4 commits into from
Sep 20, 2017

Conversation

alixhami
Copy link
Contributor

No description provided.

@alixhami alixhami added the api: bigquery Issues related to the BigQuery API. label Sep 19, 2017
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Sep 19, 2017
jba
jba reviewed Sep 19, 2017
View reviewed changes
bigquery/google/cloud/bigquery/client.py
"""
api_response = self._connection.api_request(
method='GET', path=table_ref.path)
return Table.from_api_repr(api_response, self)

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

bigquery/tests/unit/test_client.py Outdated
},
}
conn = client._connection = _Connection(resource)
dataset_ref = client.dataset(dataset_id)

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

bigquery/tests/system.py
@@ -402,8 +402,7 @@ def test_load_table_from_local_avro_file_then_dump_table(self):

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

@alixhami alixhami merged commit 6f71711 into googleapis:bigquery-b2 Sep 20, 2017
@alixhami alixhami deleted the bq-client-get-table branch September 20, 2017 16:38
tswast pushed a commit that referenced this pull request Sep 25, 2017
@alixhami @tswast
BigQuery: Adds client.get_table() and removes table.reload() (#4004)
71632e1 
* WIP adds client.get_table()

* BigQuery: Adds client.get_table() and removes table.reload()

* removes unnecessary variable

* adds system test for client.get_table()
tswast pushed a commit that referenced this pull request Oct 12, 2017
@alixhami @tswast
BigQuery: Adds client.get_table() and removes table.reload() (#4004)
1f4381f 
* WIP adds client.get_table()

* BigQuery: Adds client.get_table() and removes table.reload()

* removes unnecessary variable

* adds system test for client.get_table()
tswast pushed a commit that referenced this pull request Oct 16, 2017
@alixhami @tswast
BigQuery: Adds client.get_table() and removes table.reload() (#4004)
465e523 
* WIP adds client.get_table()

* BigQuery: Adds client.get_table() and removes table.reload()

* removes unnecessary variable

* adds system test for client.get_table()
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jba jba jba left review comments

@tswast tswast tswast approved these changes

@lukesneeringer lukesneeringer Awaiting requested review from lukesneeringer

@tseaver tseaver Awaiting requested review from tseaver

Assignees
No one assigned
Labels
api: bigquery Issues related to the BigQuery API. cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@alixhami @tswast @jba @googlebot