Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BigQuery: Adds client.get_dataset() and removes dataset.reload() #3973

Merged
merged 6 commits into from
Sep 15, 2017
Merged

BigQuery: Adds client.get_dataset() and removes dataset.reload() #3973

merged 6 commits into from
Sep 15, 2017

Conversation

alixhami
Copy link
Contributor

No description provided.

@alixhami alixhami added the api: bigquery Issues related to the BigQuery API. label Sep 15, 2017
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Sep 15, 2017
jba
jba suggested changes Sep 15, 2017
View reviewed changes
bigquery/google/cloud/bigquery/client.py Outdated
@@ -166,6 +166,20 @@ def dataset(self, dataset_name, project=None):

return DatasetReference(project, dataset_name)

def get_dataset(self, dataset_ref):
"""API call: refresh dataset properties via a GET request.

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

bigquery/google/cloud/bigquery/dataset.py
@@ -127,6 +127,15 @@ def dataset_id(self):
"""
return self._dataset_id

@property
def path(self):

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

bigquery/tests/unit/test_client.py Outdated
creds = _make_credentials()
http = object()
client = self._make_one(project=project, credentials=creds, _http=http)
DS_ID = '%s:%s' % (project, dataset_id)

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

@tswast tswast merged commit 40a3c54 into googleapis:bigquery-b2 Sep 15, 2017
@alixhami alixhami deleted the bq-client-get-dataset branch September 19, 2017 17:06
tswast pushed a commit that referenced this pull request Sep 25, 2017
@alixhami @tswast
BigQuery: Adds client.get_dataset() and removes dataset.reload() (#3973)
89ba5fe 
* BigQuery: Adds client.get_dataset() and removes dataset.reload()

* BigQuery: changes dataset.name to dataset.dataset_id in test

* fixes client.get_dataset() docstring and removes unnecessary test variable
tswast pushed a commit that referenced this pull request Oct 12, 2017
@alixhami @tswast
BigQuery: Adds client.get_dataset() and removes dataset.reload() (#3973)
4e94c48 
* BigQuery: Adds client.get_dataset() and removes dataset.reload()

* BigQuery: changes dataset.name to dataset.dataset_id in test

* fixes client.get_dataset() docstring and removes unnecessary test variable
tswast pushed a commit that referenced this pull request Oct 16, 2017
@alixhami @tswast
BigQuery: Adds client.get_dataset() and removes dataset.reload() (#3973)
e9bb79a 
* BigQuery: Adds client.get_dataset() and removes dataset.reload()

* BigQuery: changes dataset.name to dataset.dataset_id in test

* fixes client.get_dataset() docstring and removes unnecessary test variable
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jba jba jba approved these changes

@tswast tswast tswast approved these changes

@lukesneeringer lukesneeringer Awaiting requested review from lukesneeringer

@tseaver tseaver Awaiting requested review from tseaver

Assignees
No one assigned
Labels
api: bigquery Issues related to the BigQuery API. cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@alixhami @tswast @jba @googlebot