-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bigquery add DatasetReference class and tests #3938
bigquery add DatasetReference class and tests #3938
Conversation
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed, please reply here (e.g.
|
I signed it! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
Note: Alix and I pair programmed on this one, so it's already had a pretty thorough review.
@tswast Is the PR a first step toward something bigger? In other words, how will a |
Yes, it is the first step in something bigger. (I've shared a doc called BigQuery Python Client Libraries Redesign Proposal with you.) The most important use of this class is that there are places in the returned API resources where we just get a reference to a table or dataset. Rather than have a Table or Dataset class with no properties besides the ID filled in, I propose using reference classes to be more clear that they are just pointers. This would prevent confusion such as #3754 The reference classes would also be used as the argument to new methods such as |
866c4a8
to
26acfb5
Compare
f808fb0
to
6bd655a
Compare
CLAs look good, thanks! |
No description provided.