Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add 'QueryJob.referenced_tables' property. #3801

Merged
merged 1 commit into from
Sep 8, 2017
Merged

Add 'QueryJob.referenced_tables' property. #3801

merged 1 commit into from
Sep 8, 2017

Conversation

tseaver
Copy link
Contributor

@tseaver tseaver commented Aug 12, 2017 •
edited
Loading

Uses #3800 as a base.

Cherry-picked / fixed up from PR #3721.

@tseaver tseaver added the api: bigquery Issues related to the BigQuery API. label Aug 12, 2017
@tseaver tseaver requested review from tswast and dhermes August 12, 2017 20:48
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Aug 12, 2017
@tseaver
Copy link
Contributor Author

tseaver commented Aug 12, 2017

@tswast This version incorporates your research about overriding the dataset project, and therefore doesn't require the Client._clone method.

This was referenced Aug 12, 2017
Merged
Closed
tswast
tswast reviewed Aug 14, 2017
View reviewed changes
Copy link
Contributor

@tswast tswast left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM once requested changes are made to base PR.

@tseaver
Copy link
Contributor Author

tseaver commented Sep 7, 2017

Rebased after merging #3800 to the bigquery-b2 branch, with only the final commit. I will merge once the CircleCI build passes the bigquery test section.

@tseaver
Copy link
Contributor Author

tseaver commented Sep 7, 2017

Hmm, I have no idea why the CircleCI tests are not running. @dhermes, @lukesneeringer any clue?

@dhermes
Copy link
Contributor

dhermes commented Sep 7, 2017

Web-scale? Occasionally the webhooks get dropped. It's possible to see in the settings for this repo, I just don't have access to those anymore.

@dhermes
Copy link
Contributor

dhermes commented Sep 7, 2017

From https://status.github.com/

screenshot from 2017-09-07 15-16-52

@tseaver tseaver merged commit e05e50b into googleapis:bigquery-b2 Sep 8, 2017
@tseaver tseaver deleted the bigquery-b2-queryjob-referenced_tables branch September 8, 2017 11:49
tseaver added a commit that referenced this pull request Sep 11, 2017
@tseaver
Add 'QueryJob.referenced_tables' property. (#3801)
4fed34c
tswast pushed a commit that referenced this pull request Sep 25, 2017
@tseaver @tswast
Add 'QueryJob.referenced_tables' property. (#3801)
aee8ab1
tswast pushed a commit that referenced this pull request Oct 12, 2017
@tseaver @tswast
Add 'QueryJob.referenced_tables' property. (#3801)
d4e2feb
tswast pushed a commit that referenced this pull request Oct 16, 2017
@tseaver @tswast
Add 'QueryJob.referenced_tables' property. (#3801)
d20afc4
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tswast tswast tswast approved these changes

@dhermes dhermes Awaiting requested review from dhermes

Assignees
No one assigned
Labels
api: bigquery Issues related to the BigQuery API. cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@tseaver @dhermes @tswast @googlebot