Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add 'QueryJob.query_plan' property. #3799

Merged
merged 3 commits into from
Sep 7, 2017
Merged

Add 'QueryJob.query_plan' property. #3799

merged 3 commits into from
Sep 7, 2017

Conversation

tseaver
Copy link
Contributor

@tseaver tseaver commented Aug 12, 2017

Cherry-picked from PR #3721

@tseaver tseaver added the api: bigquery Issues related to the BigQuery API. label Aug 12, 2017
@tseaver tseaver requested review from tswast and dhermes August 12, 2017 19:34
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Aug 12, 2017
@tseaver tseaver mentioned this pull request Aug 12, 2017
Closed
18 tasks
@tseaver tseaver mentioned this pull request Aug 12, 2017
Merged
@tseaver
Copy link
Contributor Author

tseaver commented Aug 12, 2017

@tswast I noted your question about creating a to-be-written QueryPlanEntry class: here, because the values are "dumb data" (the class would have no methods except those to marshall instances from the JSON resource), I think it is better to just leave them as dicts.

This is different for referenced_tables and unused_query_parameters, where we already have domain objects which correspond to those resources.

@tseaver tseaver mentioned this pull request Aug 12, 2017
Merged
tswast
tswast reviewed Aug 14, 2017
View reviewed changes
bigquery/tests/unit/test_job.py Outdated
'computeRatioMax': 1.09861,
'writeRatioAvg': 3.32193,
'writeRatioMax': 2.30258,
'recordsRead': 100,

This comment was marked as spam.

Sign in to view

tswast
tswast reviewed Aug 14, 2017
View reviewed changes
bigquery/tests/unit/test_job.py Outdated
'writeRatioAvg': 3.32193,
'writeRatioMax': 2.30258,
'recordsRead': 100,
'recordsWritten': 1,

This comment was marked as spam.

Sign in to view

@tswast
Copy link
Contributor

tswast commented Aug 14, 2017

Note: I still think a class would be useful for string to int conversion, but it was only a P2 requirement from BQ team, so I won't block the PR.

tswast
tswast requested changes Aug 18, 2017
View reviewed changes
bigquery/google/cloud/bigquery/job.py
@@ -1278,6 +1284,20 @@ def from_api_repr(cls, resource, client):
job._set_properties(resource)
return job

@property
def query_plan(self):

This comment was marked as spam.

Sign in to view

@tseaver
Copy link
Contributor Author

tseaver commented Sep 7, 2017

@tswast db24010 should address your requested changes.

Note: that commit adds 350 lines of code for very little tangible benefit: I can't imagine anybody writing code which depends on the fact that records_read / records_written are integers.

tswast
tswast approved these changes Sep 7, 2017
View reviewed changes
Copy link
Contributor

@tswast tswast left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

The new class will definitely be a usability improvement over using dictionaries. I agree that usage will likely be low. That's why it was a P2 item in the requirements doc from the BQ eng team.

@tseaver tseaver merged commit 019b99f into googleapis:bigquery-b2 Sep 7, 2017
@tseaver tseaver deleted the bigquery-b2-queryjob-query_plan branch September 7, 2017 19:05
tseaver added a commit that referenced this pull request Sep 11, 2017
@tseaver
Add 'QueryJob.query_plan' property. (#3799)
029082f
tswast pushed a commit that referenced this pull request Sep 25, 2017
@tseaver @tswast
Add 'QueryJob.query_plan' property. (#3799)
33ef5db
tswast pushed a commit that referenced this pull request Oct 12, 2017
@tseaver @tswast
Add 'QueryJob.query_plan' property. (#3799)
040a39e
tswast pushed a commit that referenced this pull request Oct 16, 2017
@tseaver @tswast
Add 'QueryJob.query_plan' property. (#3799)
828ad3a
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tswast tswast tswast approved these changes

@dhermes dhermes Awaiting requested review from dhermes

Assignees
No one assigned
Labels
api: bigquery Issues related to the BigQuery API. cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tseaver @tswast @googlebot