Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make Datastore doctests use a namespace. #3793

Merged
merged 1 commit into from
Aug 11, 2017

Conversation

lukesneeringer
Copy link
Contributor

Fixes #3232.

Running nox -s doctests passes locally (I expect CI will not check it until post-merge):

$ nox -s doctests
nox > Running session doctests
nox > The virtualenv name was hashed to avoid being too long.
nox > virtualenv /usr/local/google/home/lukesneeringer/Code/Google/google-cloud-python/datastore/.nox/765eb60c -p python3.6
nox > chdir /usr/local/google/home/lukesneeringer/Code/Google/google-cloud-python/datastore
nox > pip install --upgrade mock pytest sphinx ../core/
nox > pip install --upgrade ../test_utils/
nox > pip install --upgrade .
nox > py.test --quiet tests/doctests.py
.
1 passed in 12.24 seconds
nox > Session doctests successful. :)

@lukesneeringer lukesneeringer self-assigned this Aug 11, 2017
@lukesneeringer lukesneeringer requested a review from dhermes August 11, 2017 17:25
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Aug 11, 2017
@lukesneeringer
Copy link
Contributor Author

P.S. It is really hard to edit anything with three-space indenting.

Copy link
Contributor

@dhermes dhermes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursory LGTM.

Note there is still an open issue (#3481) because these doctests are not performing cleanup as expected. When I last dug into it, the issue was the difference between the behavior of testcleanup (in Sphinx) between Python 2 and 3.

@lukesneeringer lukesneeringer merged commit 09b0cb7 into googleapis:master Aug 11, 2017
@lukesneeringer lukesneeringer deleted the issue-3232 branch August 11, 2017 17:42
landrito pushed a commit to landrito/google-cloud-python that referenced this pull request Aug 21, 2017
landrito pushed a commit to landrito/google-cloud-python that referenced this pull request Aug 22, 2017
landrito pushed a commit to landrito/google-cloud-python that referenced this pull request Aug 22, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants