Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Wait for load jobs to complete in system tests. #3782

Merged
merged 3 commits into from
Aug 11, 2017
Merged

Wait for load jobs to complete in system tests. #3782

merged 3 commits into from
Aug 11, 2017

Conversation

tswast
Copy link
Contributor

@tswast tswast commented Aug 9, 2017 •
edited
Loading

Specify job ID in BQ DB-API DML tests to allow for further test flake
debugging.

Attempting to debug #3742

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Aug 9, 2017
@tswast
Copy link
Contributor Author

tswast commented Aug 9, 2017

On closer look, the job.result() calls might be redundant.

@lukesneeringer
Copy link
Contributor

@tswast Do you want this merged?

dhermes
dhermes reviewed Aug 10, 2017
View reviewed changes
bigquery/tests/system.py Outdated
Config.CURSOR.execute(query_template.format(dataset_name, table_name))
Config.CURSOR.execute(
query_template.format(dataset_name, table_name),
job_id='test_dbapi_w_dml_{}'.format(str(uuid.uuid4())))

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

@tswast tswast changed the title BQ: wait for load jobs to complete in system tests. DO_NOT_MERGE BQ: wait for load jobs to complete in system tests. Aug 10, 2017
@lukesneeringer
Copy link
Contributor

That answers that. :-)

@lukesneeringer lukesneeringer added the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Aug 10, 2017
@lukesneeringer lukesneeringer changed the title DO_NOT_MERGE BQ: wait for load jobs to complete in system tests. Wait for load jobs to complete in system tests. Aug 10, 2017
@lukesneeringer lukesneeringer added the api: bigquery Issues related to the BigQuery API. label Aug 10, 2017
@tswast tswast removed the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Aug 10, 2017
@tswast
Copy link
Contributor Author

tswast commented Aug 10, 2017

I updated the .result() futures API calls to have a 2 minute timeout rather than potentially hang forever. I think the .result() was redundant with the retry until job done calls, so I removed those, too.

@lukesneeringer lukesneeringer merged commit 5145022 into googleapis:master Aug 11, 2017
@tswast tswast deleted the bq-3742-flake branch August 11, 2017 15:32
landrito pushed a commit to landrito/google-cloud-python that referenced this pull request Aug 21, 2017
@tswast @landrito
Wait for load jobs to complete in system tests. (googleapis#3782)
9c23e57
landrito pushed a commit to landrito/google-cloud-python that referenced this pull request Aug 22, 2017
@tswast @landrito
Wait for load jobs to complete in system tests. (googleapis#3782)
7ced18b
landrito pushed a commit to landrito/google-cloud-python that referenced this pull request Aug 22, 2017
@tswast @landrito
Wait for load jobs to complete in system tests. (googleapis#3782)
066f540
@lukesneeringer lukesneeringer mentioned this pull request Aug 24, 2017
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dhermes dhermes dhermes left review comments

@lukesneeringer lukesneeringer lukesneeringer approved these changes

Assignees
No one assigned
Labels
api: bigquery Issues related to the BigQuery API. cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@tswast @lukesneeringer @dhermes @googlebot