Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sprinkle majyk retry fairy dust. #3720

Merged
merged 1 commit into from
Aug 2, 2017
Merged

Sprinkle majyk retry fairy dust. #3720

merged 1 commit into from
Aug 2, 2017

Conversation

tseaver
Copy link
Contributor

@tseaver tseaver commented Aug 2, 2017

Closes #3510

/cc @bjwatson

@tseaver tseaver added api: pubsub Issues related to the Pub/Sub API. flaky labels Aug 2, 2017
@tseaver tseaver requested a review from dhermes August 2, 2017 20:15
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Aug 2, 2017
dhermes
dhermes approved these changes Aug 2, 2017
View reviewed changes
Copy link
Contributor

@dhermes dhermes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM though I am no fan of lamdba

@tseaver
Copy link
Contributor Author

tseaver commented Aug 2, 2017

I initially pushed this branch to my own fork, but then pushed it here to get system tests to run. Anybody know how I get the PR to point at the local branch?

@tseaver tseaver merged commit 3e8d53c into googleapis:master Aug 2, 2017
@dhermes
Copy link
Contributor

dhermes commented Aug 2, 2017

How do you mean? What is not as you expect? I see

@tseaver wants to merge 1 commit into GoogleCloudPlatform:master from tseaver:3510-pubsub-flaky-snapshot-systest

@tseaver
Copy link
Contributor Author

tseaver commented Aug 2, 2017

Funny, I feel the same way about mock.patch. :)

@tseaver tseaver deleted the 3510-pubsub-flaky-snapshot-systest branch August 2, 2017 20:20
@tseaver
Copy link
Contributor Author

tseaver commented Aug 2, 2017

I wanted to switch the PR to be "from" the branch in this repo, instead of the one in my fork. Github allows switching the base branch but not the other.

@dhermes dhermes mentioned this pull request Aug 2, 2017
Closed
landrito pushed a commit to landrito/google-cloud-python that referenced this pull request Aug 21, 2017
@tseaver @landrito
Sprinkle majyk retry fairy dust. (googleapis#3720)
1a09d68 
Closes googleapis#3510
landrito pushed a commit to landrito/google-cloud-python that referenced this pull request Aug 22, 2017
@tseaver @landrito
Sprinkle majyk retry fairy dust. (googleapis#3720)
0f1cbdc 
Closes googleapis#3510
landrito pushed a commit to landrito/google-cloud-python that referenced this pull request Aug 22, 2017
@tseaver @landrito
Sprinkle majyk retry fairy dust. (googleapis#3720)
5f3fcd1 
Closes googleapis#3510
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dhermes dhermes dhermes approved these changes

Assignees
No one assigned
Labels
api: pubsub Issues related to the Pub/Sub API. cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tseaver @dhermes @googlebot