Translate GA #3650
Merged
Translate GA #3650
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 4 commits
July 13, 2017 13:57
This commit does two things: * Moves the library proper into a versioned namespace. * Removes the BASE/NMT enum; the API producers want this to be a plain string. And then it flips the version number to 1.0.
lukesneeringer
commented
Jul 21, 2017
pubsub/nox.py
Outdated
| @@ -34,14 +34,15 @@ def unit_tests(session, python_version): | |||
| session.virtualenv_dirname = 'unit-' + python_version | |||
|
|
|||
| # Install all test dependencies, then install this package in-place. | |||
| session.install('mock', 'pytest', 'pytest-cov', *LOCAL_DEPS) | |||
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
dhermes
approved these changes
Jul 21, 2017
There was a problem hiding this comment.
@lukesneeringer I'm surprised there are so few changes here. What am I missing?
LGTM
| :param model: (Optional) The model used to translate the text. The | ||
| only accepted values are :attr:`BASE` and :attr:`NMT`. | ||
| :param model: (Optional) The model used to translate the text, such | ||
| as ``'base'`` or ``'nmt'``. |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
| @@ -56,7 +56,7 @@ | |||
|
|
|||
| setup( | |||
| name='google-cloud-translate', | |||
| version='0.25.0', | |||
| version='1.0.0', | |||
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
| @@ -56,7 +56,7 @@ def test_translate(self): | |||
| values = ['hvala ti', 'dankon', | |||
| 'Me llamo Jeff', 'My name is Jeff'] | |||
| translations = Config.CLIENT.translate( | |||
| values, target_language='de', model=translate.NMT) | |||
| values, target_language='de', model='nmt') | |||
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
landrito
pushed a commit
to landrito/google-cloud-python
that referenced
this pull request
Aug 21, 2017
landrito
pushed a commit
to landrito/google-cloud-python
that referenced
this pull request
Aug 22, 2017
landrito
pushed a commit
to landrito/google-cloud-python
that referenced
this pull request
Aug 22, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request bumps Translate to GA status, and should be followed by a release.
There are a couple of last minute changes:
translatetotranslate_v2, with a alias intranslate.