Removing google-cloud-core dependency in test_utils package.

[dhermes]

@lukesneeringer Why is this a dependency in the test_utils package?

[tseaver]

@dhermes enviornment variables:

$ git grep "from google.cloud" test_utils/ 
test_utils/scripts/run_emulator.py:from google.cloud.environment_vars import BIGTABLE_EMULATOR
test_utils/scripts/run_emulator.py:from google.cloud.environment_vars import GCD_DATASET
test_utils/scripts/run_emulator.py:from google.cloud.environment_vars import GCD_HOST
test_utils/scripts/run_emulator.py:from google.cloud.environment_vars import PUBSUB_EMULATOR

[dhermes]

Ha. Lame.

I'm going to leave this un-merged for at least 12 hours. I want to see if @lukesneeringer has anything to chime in with.

[theacodes]

weird that test_utils is its own package. Couldn't we just roll it into google-cloud-core? google.cloud._internal.testing?

[dhermes]

I disagree. It's weird to put testing helpers in code that users have installed on their machines.

[theacodes]

I mostly agree, but lesser of two evils - google-cloud-core is an "infrastructure" package (like gax), so I am not morally opposed to it having helpers for both creating packages and tests for those packages.

[tseaver]

FWIW, We actually to have google.cloud._testing in core.

[dhermes]

@tseaver Yes I'm aware, and would love to see that module either removed (due to better usage of mock) or put outside of source that is shipped to users.

[lukesneeringer]

weird that test_utils is its own package. Couldn't we just roll it into google-cloud-core? google.cloud._internal.testing?

I did this originally and @dhermes made me change it. I would still prefer that.

[dhermes]

Ya'll got me feeling crazy now 😀

[dhermes]

So this discussion shouldn't block the "bad dep" we currently have in the source tree.

Shall I file an issue to move the discussion and then merge this issue?

[lukesneeringer]

If removing the dep does not break anything, I have no objection.

[dhermes]

SGTM @lukesneeringer, just amended the commit so that it's just a removal. Fingers crossed.

[dhermes]

Aw man, no packages to test:

#!/bin/bash -eo pipefail
python3.6 test_utils/scripts/get_target_packages.py > ~/target_packages
cat ~/target_packages

[dhermes]

I'm just going to merge this and if there is carnage we can roll it back ASAP.