Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #164: Map HTTP error responses for storage onto specific exception classes. #355

Merged
merged 2 commits into from
Nov 7, 2014
Merged

Fix #164: Map HTTP error responses for storage onto specific exception classes. #355

merged 2 commits into from
Nov 7, 2014

Conversation

tseaver
Copy link
Contributor

@tseaver tseaver commented Nov 7, 2014

Fixes #164.

@tseaver tseaver added type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design. api: storage Issues related to the Cloud Storage API. labels Nov 7, 2014
@coveralls
Copy link

Coverage Status

Changes Unknown when pulling 89788fb on tseaver:164-add_http_specific_exceptions into * on GoogleCloudPlatform:master*.

dhermes
dhermes reviewed Nov 7, 2014
View reviewed changes
gcloud/storage/exceptions.py
return error


for name, value in globals().items():

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

@tseaver
Copy link
Contributor Author

tseaver commented Nov 7, 2014

@dhermes reworked to recurse over __subclasses__.

@coveralls
Copy link

Coverage Status

Changes Unknown when pulling e322609 on tseaver:164-add_http_specific_exceptions into * on GoogleCloudPlatform:master*.

@dhermes
Copy link
Contributor

dhermes commented Nov 7, 2014

LGTM

@tseaver
Copy link
Contributor Author

tseaver commented Nov 7, 2014

It would be good if we could document the specific exception types better, but the storage API docs for the various endpoints don't normally detail the error responses possible (we've inferred a few in the past).

tseaver added a commit that referenced this pull request Nov 7, 2014
@tseaver
Merge pull request #355 from tseaver/164-add_http_specific_exceptions
efae0ef 
Fix #164:  Map HTTP error responses for storage onto specific exception classes.
@tseaver tseaver merged commit efae0ef into googleapis:master Nov 7, 2014
@tseaver tseaver deleted the 164-add_http_specific_exceptions branch November 7, 2014 22:08
@tseaver tseaver mentioned this pull request Nov 13, 2014
Closed
atulep pushed a commit that referenced this pull request Apr 3, 2023
@gcf-owl-bot
docs: update docstrings to use absolute links (#355)
f3c7c0c 
* fix: use full link in comment to fix JSDoc broken link

Committer: @summer-ji-eng
PiperOrigin-RevId: 440481666

Source-Link: googleapis/googleapis@6a21110

Source-Link: googleapis/googleapis-gen@e6e39af
Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiZTZlMzlhZmYzM2I5MGE2M2ExOGU5MDgxZTQ4MGIwOGE0MWM1NDhhYyJ9

* 🦉 Updates from OwlBot post-processor

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
atulep pushed a commit that referenced this pull request Apr 6, 2023
@gcf-owl-bot
docs: update docstrings to use absolute links (#355)
2daaf49 
* fix: use full link in comment to fix JSDoc broken link

Committer: @summer-ji-eng
PiperOrigin-RevId: 440481666

Source-Link: googleapis/googleapis@6a21110

Source-Link: googleapis/googleapis-gen@e6e39af
Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiZTZlMzlhZmYzM2I5MGE2M2ExOGU5MDgxZTQ4MGIwOGE0MWM1NDhhYyJ9

* 🦉 Updates from OwlBot post-processor

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
atulep pushed a commit that referenced this pull request Apr 6, 2023
@gcf-owl-bot
docs: update docstrings to use absolute links (#355)
7396df5 
* fix: use full link in comment to fix JSDoc broken link

Committer: @summer-ji-eng
PiperOrigin-RevId: 440481666

Source-Link: googleapis/googleapis@6a21110

Source-Link: googleapis/googleapis-gen@e6e39af
Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiZTZlMzlhZmYzM2I5MGE2M2ExOGU5MDgxZTQ4MGIwOGE0MWM1NDhhYyJ9

* 🦉 Updates from OwlBot post-processor

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
atulep pushed a commit that referenced this pull request Apr 18, 2023
@gcf-owl-bot
docs: update docstrings to use absolute links (#355)
56e3435 
* fix: use full link in comment to fix JSDoc broken link

Committer: @summer-ji-eng
PiperOrigin-RevId: 440481666

Source-Link: googleapis/googleapis@6a21110

Source-Link: googleapis/googleapis-gen@e6e39af
Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiZTZlMzlhZmYzM2I5MGE2M2ExOGU5MDgxZTQ4MGIwOGE0MWM1NDhhYyJ9

* 🦉 Updates from OwlBot post-processor

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
parthea added a commit that referenced this pull request Jun 4, 2023
@renovate-bot @gcf-owl-bot @parthea
chore(deps): update all dependencies (#355)
5745b62 
* chore(deps): update all dependencies

* 🦉 Updates from OwlBot post-processor

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

* revert

Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
Co-authored-by: Anthonios Partheniou <partheniou@google.com>
parthea pushed a commit that referenced this pull request Jun 4, 2023
@gcf-owl-bot
chore: resolve issue with prerelease presubmit [autoapprove] (#355)
87073f7 
Source-Link: googleapis/synthtool@1b9ad76
Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:9db98b055a7f8bd82351238ccaacfd3cda58cdf73012ab58b8da146368330021
parthea added a commit that referenced this pull request Jun 4, 2023
@renovate-bot @parthea
chore(deps): update dependency pytest to v7.1.3 (#355)
866fb0e 
* chore(deps): update all dependencies

* revert

Co-authored-by: Anthonios Partheniou <partheniou@google.com>
parthea pushed a commit that referenced this pull request Jul 6, 2023
@renovate-bot
chore(deps): update dependency google-api-python-client to v2.58.0 (#355
13a1538 
)
parthea pushed a commit that referenced this pull request Sep 20, 2023
@renovate-bot
chore(deps): update dependency google-cloud-retail to v1.10.2 (#355)
afd2efd
parthea pushed a commit that referenced this pull request Sep 22, 2023
@renovate-bot
chore(deps): update dependency pytest to v7.2.2 (#355)
a82875f
parthea pushed a commit that referenced this pull request Sep 22, 2023
@gcf-owl-bot
feat: new Bytes and File types POWERPOINT and EXCEL (#355)
fdc1b11 
* feat: new Bytes and File types: POWERPOINT and EXCEL

PiperOrigin-RevId: 437260831

Source-Link: googleapis/googleapis@3c34a40

Source-Link: googleapis/googleapis-gen@a403521
Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiYTQwMzUyMTNlNjg2Yjk2YWZjM2VkNjZkMGQwNDMyOGU0ZmZiZDRkMSJ9

* 🦉 Updates from OwlBot post-processor

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
parthea pushed a commit that referenced this pull request Sep 22, 2023
@gcf-owl-bot
docs: Add documentation for enums (#355)
51a0288 
* docs: Add documentation for enums

fix: Add context manager return types

chore: Update gapic-generator-python to v1.8.1
PiperOrigin-RevId: 503210727

Source-Link: googleapis/googleapis@a391fd1

Source-Link: googleapis/googleapis-gen@0080f83
Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiMDA4MGY4MzBkZWMzN2MzMzg0MTU3MDgyYmNlMjc5ZTM3MDc5ZWE1OCJ9

* 🦉 Updates from OwlBot post-processor

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
parthea pushed a commit that referenced this pull request Sep 22, 2023
@gcf-owl-bot
chore: remove 'pip install' statements from python_library templates …
28eb646 
…[autoapprove] (#355)

Source-Link: googleapis/synthtool@1f37ce7
Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:8e84e0e0d71a0d681668461bba02c9e1394c785f31a10ae3470660235b673086

Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
parthea pushed a commit that referenced this pull request Oct 21, 2023
@gcf-owl-bot
feat: Update Compute Engine API to revision 20221011 (#736) (#355)
7d30915 
* feat: Update Compute Engine API to revision 20221011 (#736)

Source-Link: googleapis/googleapis@cb8c914

Source-Link: googleapis/googleapis-gen@1174767
Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiMTE3NDc2NzQ0NmM2NTAyNzFmMzk3ZWM2ZWY1NDEwMWJlNDRjZGNiNCJ9

* 🦉 Updates from OwlBot post-processor

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
parthea pushed a commit that referenced this pull request Oct 21, 2023
@release-please
chore(main): release 2.11.0 (#355)
48c7659 
Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
parthea pushed a commit that referenced this pull request Oct 21, 2023
@renovate-bot
chore(deps): update dependency google-cloud-texttospeech to v2.11.0 (#…
3a94034 
…355)
parthea pushed a commit that referenced this pull request Oct 21, 2023
@gcf-owl-bot
chore(python): auto approve template changes (#355)
a4b339c 
Source-Link: googleapis/synthtool@453a5d9
Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:81ed5ecdfc7cac5b699ba4537376f3563f6f04122c4ec9e735d3b3dc1d43dd32
parthea pushed a commit that referenced this pull request Oct 21, 2023
@gcf-owl-bot
fix: Add async context manager return types (#355)
9e940ef 
* fix: Add async context manager return types

chore: Mock return_value should not populate oneof message fields

chore: Support snippet generation for services that only support REST transport

chore: Update gapic-generator-python to v1.11.0
PiperOrigin-RevId: 545430278

Source-Link: googleapis/googleapis@601b532

Source-Link: googleapis/googleapis-gen@b3f18d0
Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiYjNmMThkMGY2NTYwYTg1NTAyMmZkMDU4ODY1ZTc2MjA0NzlkN2FmOSJ9

* 🦉 Updates from OwlBot post-processor

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

---------

Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
parthea pushed a commit that referenced this pull request Oct 21, 2023
@gcf-owl-bot
build(deps): bump requests to 2.31.0 [autoapprove] (#355)
6cd1007 
Source-Link: https://togithub.com/googleapis/synthtool/commit/30bd01b4ab78bf1b2a425816e15b3e7e090993dd
Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:9bc5fa3b62b091f60614c08a7fb4fd1d3e1678e326f34dd66ce1eefb5dc3267b
parthea pushed a commit that referenced this pull request Oct 21, 2023
@gcf-owl-bot
chore(python): update dependencies in .kokoro/requirements.txt [autoa…
b7b784c 
…pprove] (#355)

Source-Link: https://togithub.com/googleapis/synthtool/commit/e3a1277ac35fc88c09db1930533e24292b132ced
Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:452901c74a22f9b9a3bd02bce780b8e8805c97270d424684bff809ce5be8c2a2
parthea pushed a commit that referenced this pull request Oct 22, 2023
@gcf-owl-bot
docs: update docstrings to use absolute links (#355)
384fb03 
* fix: use full link in comment to fix JSDoc broken link

Committer: @summer-ji-eng
PiperOrigin-RevId: 440481666

Source-Link: googleapis/googleapis@6a21110

Source-Link: googleapis/googleapis-gen@e6e39af
Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiZTZlMzlhZmYzM2I5MGE2M2ExOGU5MDgxZTQ4MGIwOGE0MWM1NDhhYyJ9

* 🦉 Updates from OwlBot post-processor

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
api: storage Issues related to the Cloud Storage API. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

In storage.connection.Connection.api_request, make response checking more robust
3 participants
@tseaver @coveralls @dhermes