Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add back pylint as info-only for core #3515

Merged
merged 2 commits into from
Jun 22, 2017
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion .gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -56,7 +56,8 @@ coverage.xml
system_tests/local_test_setup

# Make sure a generated file isn't accidentally committed.
scripts/pylintrc_reduced
pylintrc
pylintrc.test

# Directories used for creating generated PB2 files
generated_python/
Expand Down
14 changes: 9 additions & 5 deletions core/nox.py
Original file line number Diff line number Diff line change
Expand Up @@ -14,8 +14,6 @@

from __future__ import absolute_import

import os

import nox


Expand Down Expand Up @@ -43,15 +41,21 @@ def unit_tests(session, python_version):

@nox.session
def lint(session):
"""Run flake8.
"""Run linters.

Returns a failure if flake8 finds linting errors or sufficiently
Returns a failure if the linters find linting errors or sufficiently
serious code quality issues.
"""
session.interpreter = 'python3.6'
session.install('flake8')
session.install('flake8', 'pylint', 'gcp-devrel-py-tools')
session.install('.')
session.run('flake8', 'google/cloud/core')
session.run(
'gcp-devrel-py-tools', 'run-pylint',

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

'--library-filesets', 'google',
'--test-filesets', 'tests',
# Temporarily allow this to fail.
success_codes=range(0, 100))

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.



@nox.session
Expand Down