Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

iam.Policy: return empty set on missing key. #3424

Merged
merged 1 commit into from
May 16, 2017
Merged

iam.Policy: return empty set on missing key. #3424

merged 1 commit into from
May 16, 2017

Conversation

tseaver
Copy link
Contributor

@tseaver tseaver commented May 16, 2017

Closes #3346.

@tseaver tseaver added auth api: core type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design. labels May 16, 2017
@tseaver tseaver requested review from theacodes and dhermes May 16, 2017 18:46
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label May 16, 2017
@dhermes
Copy link
Contributor

dhermes commented May 16, 2017

Do we really need a defaultdict to solve #3346?

theacodes
theacodes approved these changes May 16, 2017
View reviewed changes
Copy link
Contributor

@theacodes theacodes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This LGTM, but if @dhermes prefers a different approach then I defer to him.

@dhermes
Copy link
Contributor

dhermes commented May 16, 2017

Nah if it's OK with @jonparrott it's OK with me

@tseaver tseaver merged commit 77a7fa0 into googleapis:master May 16, 2017
@tseaver tseaver deleted the 3346-core-iam_policy_defaultdict_set branch May 16, 2017 20:58
@tseaver tseaver mentioned this pull request Jun 7, 2017
Closed
@tseaver tseaver mentioned this pull request Jun 26, 2017
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@theacodes theacodes theacodes approved these changes

@dhermes dhermes Awaiting requested review from dhermes

Assignees
No one assigned
Labels
api: core auth cla: yes This human has signed the Contributor License Agreement. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@tseaver @dhermes @theacodes @googlebot