Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Getters for row key and row table #3408

Merged
merged 2 commits into from
May 12, 2017
Merged

Getters for row key and row table #3408

merged 2 commits into from
May 12, 2017

Conversation

CuriousDima
Copy link
Contributor

Pulling out non-controversial part of #3401 for #2411.

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label May 12, 2017
@dhermes
Copy link
Contributor

dhermes commented May 12, 2017

@skyfox This LGTM, I restarted your build, that failure seems spurious. Fingers crossed.

@dhermes dhermes added the api: bigtable Issues related to the Bigtable API. label May 12, 2017
@dhermes
Copy link
Contributor

dhermes commented May 12, 2017

@skyfox I manually rebased your branch onto the latest version of master (sorry if it caused any confusion).

@googlebot
Copy link

So there's good news and bad news.

👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there.

😕 The bad news is that it appears that one or more commits were authored by someone other than the pull request submitter. We need to confirm that they're okay with their commits being contributed to this project. Please have them confirm that here in the pull request.

Note to project maintainer: This is a terminal state, meaning the cla/google commit status will not change from this state. It's up to you to confirm consent of the commit author(s) and merge this pull request when appropriate.

@googlebot googlebot added cla: no This human has *not* signed the Contributor License Agreement. and removed cla: yes This human has signed the Contributor License Agreement. labels May 12, 2017
@dhermes
Copy link
Contributor

dhermes commented May 12, 2017

@skyfox Some lines had trailing whitespace and it failed the lint part of the build. I sent a follow-up commit to your branch to resolve (sorry if that was not OK).

I have my editor configured to just strip any trailing whitespace from lines on save.

@dhermes dhermes merged commit ecd4da4 into googleapis:master May 12, 2017
@CuriousDima
Copy link
Contributor Author

Thank you for merging!
Going to fix comments for the second part.

@CuriousDima CuriousDima deleted the table-pr branch May 13, 2017 16:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: bigtable Issues related to the Bigtable API. cla: no This human has *not* signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants