Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Making Subscription.reload() update the topic if unset. #3397

Merged
merged 1 commit into from
May 16, 2017
Merged

Making Subscription.reload() update the topic if unset. #3397

merged 1 commit into from
May 16, 2017

Conversation

dhermes
Copy link
Contributor

@dhermes dhermes commented May 10, 2017

Also:

  • removing Subscription._project and Snapshot._project since they are never used (and they shadow data that they shouldn't).
  • my auto-save got rid of a lot of trailing whitespace

@dhermes dhermes added the api: pubsub Issues related to the Pub/Sub API. label May 10, 2017
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label May 10, 2017
@dhermes dhermes force-pushed the pubsub-topic-subs-reload branch 2 times, most recently from f495808 to a1c10ba Compare May 16, 2017 17:19
@dhermes
Making Subscription.reload() update the topic if unset.
4835bc5 
Also: removing Subscription._project and Snapshot._project since
they are never used (and they shadow data that they shouldn't).
@dhermes dhermes force-pushed the pubsub-topic-subs-reload branch from a1c10ba to 4835bc5 Compare May 16, 2017 17:28
@dhermes dhermes merged commit 3dbc8e3 into googleapis:master May 16, 2017
@dhermes dhermes deleted the pubsub-topic-subs-reload branch May 16, 2017 17:34
@tseaver tseaver mentioned this pull request Jun 26, 2017
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tseaver tseaver tseaver approved these changes

Assignees

@lukesneeringer lukesneeringer

@tseaver tseaver

Labels
api: pubsub Issues related to the Pub/Sub API. cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@dhermes @tseaver @lukesneeringer @googlebot