Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Correct speech Operation docstring #3379

Merged
merged 1 commit into from
May 5, 2017
Merged

Correct speech Operation docstring #3379

merged 1 commit into from
May 5, 2017

Conversation

cfperez
Copy link
Contributor

@cfperez cfperez commented May 5, 2017

ValueError is raised when there are no results, not when there is more than one result, which is what the docstring says.

@cfperez
Correct speech Operation docstring
e3e1b96 
ValueError is raised when there are no results, not when there is more than one result, which is what the docstring says.
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label May 5, 2017
cfperez
cfperez commented May 5, 2017
View reviewed changes
Copy link
Contributor Author

@cfperez cfperez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See L64

@dhermes
Copy link
Contributor

dhermes commented May 5, 2017

LGTM

@dhermes
Copy link
Contributor

dhermes commented May 5, 2017

Thanks @cfperez. No need to wait on CI since your change is docs only (and even more, these docs don't get built since a non-public method)

@dhermes dhermes merged commit 98c9cb7 into googleapis:master May 5, 2017
@tseaver tseaver mentioned this pull request Jun 26, 2017
Merged
atulep pushed a commit that referenced this pull request Apr 3, 2023
@cfperez @dhermes
Correct speech Operation docstring (#3379)
c9b09d3 
ValueError is raised when there are no results, not when there is more than one result, which is what the docstring says.
atulep pushed a commit that referenced this pull request Apr 18, 2023
@cfperez @dhermes
Correct speech Operation docstring (#3379)
94e9d78 
ValueError is raised when there are no results, not when there is more than one result, which is what the docstring says.
parthea pushed a commit that referenced this pull request Oct 22, 2023
@cfperez @dhermes
Correct speech Operation docstring (#3379)
0744b98 
ValueError is raised when there are no results, not when there is more than one result, which is what the docstring says.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@cfperez @dhermes @googlebot