Fix #272: add 'allocate_ids' RPC to connection #299

tseaver · 2014-10-27T21:23:14Z

To ease comparison with the protobuf spec:

Reorders other RPC methods to match the order in the protobuf spec
Renames 'Connection.rollback_transaction' -> 'rollback'.

Makes it consistent w/ 'commit', as well as matching the protobuf RPC.

Fixes #272.

gcloud/datastore/connection.py

@@ -153,48 +153,72 @@ def dataset(self, *args, **kwargs):
        kwargs['connection'] = self
        return Dataset(*args, **kwargs)

-    def begin_transaction(self, dataset_id, serializable=False):
-        """Begin a transaction.
+    #


dhermes · 2014-10-27T21:34:14Z

The idea behind the rename is to match all the SomethingRequest classes defined in the proto?

If yes, I am a fan of this. If no, how serendipitous.

dhermes · 2014-10-27T21:40:44Z

Sorry for I started reviewing lookup before I realized that ada09e1 happened and confused diff and git diff.

Before I accidentally complain about non-changes, were there actual code changes in that commit or just re-org?

tseaver · 2014-10-27T21:41:47Z

Yes, matching the Request/Response classes, as well as the RPCs

tseaver · 2014-10-27T21:43:32Z

ada09e1 is only reordering the methods which map RPCs.
d5882e3 is only the 'rollback_transaction' -> 'rollback' rename.
eff498d adds the 'allocate_ids' method.

coveralls · 2014-10-27T21:44:02Z

Coverage remained the same when pulling eff498d on tseaver:272-add-allocate_ids-rpc into 6f26e98 on GoogleCloudPlatform:master.

dhermes · 2014-10-27T21:53:13Z

Both eff498d and d5882e3 LGTM but I want to try to somehow check ada09e1.

As for the re-org Connection / Dataset stuff, we can take that to another PR. I would prefer you remove the section header though since it breaks / introduces convention within this project.

@dhermes

Remove section header comments, per @dhermes feedback.

coveralls · 2014-10-27T22:18:49Z

Coverage remained the same when pulling 162f508 on tseaver:272-add-allocate_ids-rpc into 6f26e98 on GoogleCloudPlatform:master.

dhermes · 2014-10-28T00:51:47Z

OK I verified ada09e1

LGTM

I am afk (on phone) right now. Feel free to create a tracking issue for the breakup of the Connection class before merging this.

Fix #272: add 'allocate_ids' RPC to connection

Fix "keyerror" issue in beautifulsoup while checking attribute.

* docs: Fix formatting of request arg in docstring chore: Update gapic-generator-python to v1.9.1 PiperOrigin-RevId: 518604533 Source-Link: googleapis/googleapis@8a085ae Source-Link: googleapis/googleapis-gen@b2ab4b0 Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiYjJhYjRiMGEwYWUyOTA3ZTgxMmMyMDkxOThhNzRlMDg5OGFmY2IwNCJ9 * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md --------- Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>

Co-authored-by: Anthonios Partheniou <partheniou@google.com>

Source-Link: googleapis/synthtool@50db768 Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:e09366bdf0fd9c8976592988390b24d53583dd9f002d476934da43725adbb978

)

Source-Link: googleapis/synthtool@453a5d9 Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:81ed5ecdfc7cac5b699ba4537376f3563f6f04122c4ec9e735d3b3dc1d43dd32

)

Co-authored-by: Anthonios Partheniou <partheniou@google.com>

)

Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>

…299) Source-Link: googleapis/synthtool@fdba3ed Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:1f0dbd02745fb7cf255563dab5968345989308544e52b7f460deadd5e78e63b0

Source-Link: googleapis/synthtool@6ed3a83 Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:3abfa0f1886adaf0b83f07cb117b24a639ea1cb9cffe56d43280b977033563eb Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>

* chore(deps): update all dependencies * revert Co-authored-by: Anthonios Partheniou <partheniou@google.com>

Co-authored-by: Anthonios Partheniou <partheniou@google.com> Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>

Source-Link: googleapis/synthtool@050953d Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:65e656411895bff71cffcae97246966460160028f253c2e45b7a25d805a5b142 Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>

* fix(deps): require protobuf <4.0.0dev * chore(deps): bump grpc-google-iam-v1 version Co-authored-by: Dan Lee <71398022+dandhlee@users.noreply.github.com>

Source-Link: googleapis/synthtool@6fab84a Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:7cffbc10910c3ab1b852c05114a08d374c195a81cdec1d4a67a1d129331d0bfe Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>

)

* chore: Update to gapic-generator-python 1.6.0 feat(python): Add typing to proto.Message based class attributes feat(python): Snippetgen handling of repeated enum field PiperOrigin-RevId: 487326846 Source-Link: googleapis/googleapis@da380c7 Source-Link: googleapis/googleapis-gen@61ef576 Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiNjFlZjU3NjJlZTY3MzFhMGNiYmZlYTIyZmQwZWVjZWU1MWFiMWM4ZSJ9 * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md * feat: new APIs added to reflect updates to the filestore service - Add ENTERPRISE Tier - Add snapshot APIs: RevertInstance, ListSnapshots, CreateSnapshot, DeleteSnapshot, UpdateSnapshot - Add multi-share APIs: ListShares, GetShare, CreateShare, DeleteShare, UpdateShare - Add ConnectMode to NetworkConfig (for Private Service Access support) - New status codes (SUSPENDED/SUSPENDING, REVERTING/RESUMING) - Add SuspensionReason (for KMS related suspension) - Add new fields to Instance information: max_capacity_gb, capacity_step_size_gb, max_share_count, capacity_gb, multi_share_enabled PiperOrigin-RevId: 487492758 Source-Link: googleapis/googleapis@5be5981 Source-Link: googleapis/googleapis-gen@ab0e217 Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiYWIwZTIxN2Y1NjBjYzJjMWFmYzExNDQxYzJlYWI2YjY5NTBlZmQyYiJ9 * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md * fix docs build * fix repo url in setup.py Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com> Co-authored-by: Anthonios Partheniou <partheniou@google.com>

* chore(bazel): update protobuf to v3.21.7 PiperOrigin-RevId: 477955264 Source-Link: googleapis/googleapis@a724450 Source-Link: googleapis/googleapis-gen@4abcbca Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiNGFiY2JjYWVjODU1ZTc0YTBiMjJhNDk4OGNmOWUwZWI2MWE4MzA5NCJ9 * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com> Co-authored-by: Anthonios Partheniou <partheniou@google.com>

* chore: Update gapic-generator-python to v1.8.4 PiperOrigin-RevId: 507808936 Source-Link: googleapis/googleapis@64cf849 Source-Link: googleapis/googleapis-gen@53c48ca Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiNTNjNDhjYWMxNTNkM2IzN2YzZDJjMmRlYzQ4MzBjZmQ5MWVjNDE1MyJ9 * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md --------- Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>

* chore: Update gapic-generator-python to v1.18.5 PiperOrigin-RevId: 661268868 Source-Link: googleapis/googleapis@f7d214c Source-Link: googleapis/googleapis-gen@79a8411 Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiNzlhODQxMWJiZGIyNWE5ODNmYTNhYWU4YzBlMTQzMjdkZjEyOWY5NCJ9 chore: Update gapic-generator-python to v1.18.4 PiperOrigin-RevId: 657207628 Source-Link: googleapis/googleapis@33fe71e Source-Link: googleapis/googleapis-gen@e02739d Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiZTAyNzM5ZDEyMmVkMTViZDVlZjU3NzFjNTdmMTJhODNkNDdhMWRkYSJ9 chore: Update gapic-generator-python to v1.18.3 PiperOrigin-RevId: 656040068 Source-Link: googleapis/googleapis@3f4e29a Source-Link: googleapis/googleapis-gen@b8feb21 Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiYjhmZWIyMTA5ZGRlN2IwOTM4YzIyYzk5M2QwMDIyNTFhYzY3MTRkYyJ9 chore: Update gapic-generator-python to v1.18.3 PiperOrigin-RevId: 655567917 Source-Link: googleapis/googleapis@43aa65e Source-Link: googleapis/googleapis-gen@0e38378 Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiMGUzODM3ODc1MzA3NGMwZjY2ZmY2MzM0OGQ2ODY0OTI5ZTEwNGQ1YyJ9 feat(spanner): Add support for Cloud Spanner Scheduled Backups PiperOrigin-RevId: 649277844 Source-Link: googleapis/googleapis@fd7efa2 Source-Link: googleapis/googleapis-gen@50be251 Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiNTBiZTI1MTMyOWQ4ZGI1YjU1NTYyNmViZDQ4ODY3MjFmNTQ3ZDNjYyJ9 * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md --------- Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>

tseaver added 3 commits October 27, 2014 16:53

Re-order Connection's RPC methods to match protobuf spec.

ada09e1

Rename 'Connection.rollback_transaction' -> 'rollback'.

d5882e3

Makes it consistent w/ 'commit', as well as matching the protobuf RPC.

Implement 'allocate_ids' RPC on Connection.

eff498d

Fixes #272.

dhermes reviewed Oct 27, 2014
View reviewed changes

Note protobuf RPCs mapped by connection methods.

162f508

Remove section header comments, per @dhermes feedback.

tseaver mentioned this pull request Oct 28, 2014

datastore.connection.Connection has disjoint responsibilities #303

Closed

tseaver added a commit that referenced this pull request Oct 28, 2014

Merge pull request #299 from tseaver/272-add-allocate_ids-rpc

7d155f7

Fix #272: add 'allocate_ids' RPC to connection

tseaver merged commit 7d155f7 into googleapis:master Oct 28, 2014

tseaver deleted the 272-add-allocate_ids-rpc branch October 28, 2014 02:16

dhermes added the api: datastore Issues related to the Datastore API. label Dec 31, 2015

urshala pushed a commit to urshala/google-cloud-python that referenced this pull request Jan 17, 2020

Merge pull request googleapis#299 from shyamdsundar/master

8739a8f

Fix "keyerror" issue in beautifulsoup while checking attribute.

atulep pushed a commit that referenced this pull request Apr 6, 2023

chore: use python-samples-reviewers (#299)

d10cb17

atulep pushed a commit that referenced this pull request Apr 18, 2023

chore: use python-samples-reviewers (#299)

1e36bc5

parthea added a commit that referenced this pull request Jun 4, 2023

chore(deps): update all dependencies (#299)

6448767

Co-authored-by: Anthonios Partheniou <partheniou@google.com>

parthea pushed a commit that referenced this pull request Jun 4, 2023

chore(deps): update dependency google-cloud-datalabeling to v1.8.0 (#299

db8cadf

)

parthea pushed a commit that referenced this pull request Jun 4, 2023

chore(deps): update dependency google-cloud-talent to v2.7.3 (#299)

b706d1d

parthea pushed a commit that referenced this pull request Jun 4, 2023

chore(deps): update dependency google-cloud-pubsub to v2.11.0 (#299)

26d6f64

parthea pushed a commit that referenced this pull request Jul 6, 2023

chore(deps): update dependency google-api-python-client to v2.44.0 (#299

be1fe3f

)

parthea pushed a commit that referenced this pull request Aug 15, 2023

chore(deps): update dependency pytest to v7.1.2 (#299)

53a5296

parthea added a commit that referenced this pull request Sep 20, 2023

chore(samples): remove env setup (#299)

bcee271

Co-authored-by: Anthonios Partheniou <partheniou@google.com>

parthea pushed a commit that referenced this pull request Sep 20, 2023

docs(samples): remove restriction of JPEGs only for overlay images (#299

008cdad

)

vchudnov-g pushed a commit that referenced this pull request Sep 20, 2023

chore: release 2.3.0 (#299)

2890672

Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>

parthea pushed a commit that referenced this pull request Sep 22, 2023

chore(main): release 1.11.0 (#299)

722652f

Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>

parthea pushed a commit that referenced this pull request Sep 22, 2023

chore(deps): update dependency google-cloud-pubsub to v2.10.0 (#299)

4d696dc

parthea pushed a commit that referenced this pull request Sep 22, 2023

chore(deps): update dependency google-cloud-container to v2.12.0 (#299)

1cc06ca

parthea pushed a commit that referenced this pull request Sep 22, 2023

chore(deps): update dependency google-cloud-dataproc to v3.1.1 (#299)

7e55df7

parthea added a commit that referenced this pull request Sep 22, 2023

chore(deps): update dependency pytest to v7.1.3 (#299)

6c619a0

* chore(deps): update all dependencies * revert Co-authored-by: Anthonios Partheniou <partheniou@google.com>

parthea added a commit that referenced this pull request Oct 21, 2023

docs(samples): Bulk insert sample (#299)

c69dde9

Co-authored-by: Anthonios Partheniou <partheniou@google.com> Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>

parthea added a commit that referenced this pull request Oct 21, 2023

fix(deps): require protobuf <4.0.0dev (#299)

5a544f3

* fix(deps): require protobuf <4.0.0dev * chore(deps): bump grpc-google-iam-v1 version Co-authored-by: Dan Lee <71398022+dandhlee@users.noreply.github.com>

parthea pushed a commit that referenced this pull request Oct 21, 2023

chore(deps): update dependency google-cloud-texttospeech to v2.8.0 (#299

afbfb49

)

parthea pushed a commit that referenced this pull request Oct 21, 2023

chore: make samples 3.6 check optional (#299)

23608a3

parthea pushed a commit that referenced this pull request Oct 22, 2023

chore: use python-samples-reviewers (#299)

927a23f

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix #272: add 'allocate_ids' RPC to connection #299

Fix #272: add 'allocate_ids' RPC to connection #299

tseaver commented Oct 27, 2014

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

dhermes commented Oct 27, 2014

dhermes commented Oct 27, 2014

tseaver commented Oct 27, 2014

tseaver commented Oct 27, 2014

coveralls commented Oct 27, 2014

dhermes commented Oct 27, 2014

coveralls commented Oct 27, 2014

dhermes commented Oct 28, 2014

Fix #272: add 'allocate_ids' RPC to connection #299

Fix #272: add 'allocate_ids' RPC to connection #299

Conversation

tseaver commented Oct 27, 2014

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

dhermes commented Oct 27, 2014

dhermes commented Oct 27, 2014

tseaver commented Oct 27, 2014

tseaver commented Oct 27, 2014

coveralls commented Oct 27, 2014

dhermes commented Oct 27, 2014

coveralls commented Oct 27, 2014

dhermes commented Oct 28, 2014