Add system test for Vision Logo detection. #2788

daspecster · 2016-11-30T23:19:12Z

Towards: #2753 and #2526.

I will add the filename test after #2778 is merged.
To get this kicked off though, here are some system tests for detect_logo().

dhermes

Mostly LG but a few changes are "needed"

system_tests/run_system_test.py



 TEST_MODULES = {
    'datastore': datastore,
    'speech': speech,
+    'vision': vision,


system_tests/vision.py

+    CLIENT = None
+    TEST_BUCKET = None
+
+    LOGO_FILE = os.path.join(os.path.dirname(__file__), 'data', 'logo.png')


system_tests/vision.py

+    bucket_retry(Config.TEST_BUCKET.delete)(force=True)
+
+
+class TestSpeechClient(unittest.TestCase):


system_tests/vision.py

+            value.delete()
+
+    def _assert_logo(self, logo):
+        self.assertEqual(logo.description, 'Google')


daspecster · 2016-12-02T18:39:55Z

I added the filename test as well.

system-tests runtests: commands[1] | python /Users/daspecster/Documents/google/google-cloud-python/system_tests/attempt_system_tests.py vision
test_detect_logos_content (vision.TestVisionClient) ... ok
test_detect_logos_filename (vision.TestVisionClient) ... ok
test_detect_logos_gcs (vision.TestVisionClient) ... ok

----------------------------------------------------------------------
Ran 3 tests in 5.540s

OK
____________________________________________________ summary _____________________________________________________
  system-tests: commands succeeded
  congratulations :)

daspecster · 2016-12-02T20:14:15Z

Squashed! And cancelled travis #SaveCycles.

…tests Add system test for Vision Logo detection.

daspecster added testing api: vision Issues related to the Cloud Vision API. labels Nov 30, 2016

daspecster assigned tseaver and dhermes Nov 30, 2016

googlebot added the cla: yes This human has signed the Contributor License Agreement. label Nov 30, 2016

daspecster mentioned this pull request Nov 30, 2016

Tracking Vision Development. #2753

Closed

10 tasks

dhermes reviewed Dec 1, 2016

View reviewed changes

daspecster force-pushed the vision-add-system-tests branch from bd0270b to c6019d8 Compare December 2, 2016 18:38

dhermes approved these changes Dec 2, 2016

View reviewed changes

Add system test for Vision Logo detection.

e6ea013

daspecster force-pushed the vision-add-system-tests branch from c6019d8 to e6ea013 Compare December 2, 2016 20:14

daspecster merged commit 1650979 into googleapis:master Dec 2, 2016

daspecster deleted the vision-add-system-tests branch December 2, 2016 20:42

richkadel pushed a commit to richkadel/google-cloud-python that referenced this pull request May 6, 2017

Merge pull request googleapis#2788 from daspecster/vision-add-system-…

6be983e

…tests Add system test for Vision Logo detection.

theacodes unassigned dhermes Sep 28, 2018

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add system test for Vision Logo detection. #2788

Add system test for Vision Logo detection. #2788

daspecster commented Nov 30, 2016 •

edited

Loading

dhermes left a comment

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

daspecster commented Dec 2, 2016

daspecster commented Dec 2, 2016 •

edited

Loading

		bucket_retry(Config.TEST_BUCKET.delete)(force=True)


		class TestSpeechClient(unittest.TestCase):

Add system test for Vision Logo detection. #2788

Add system test for Vision Logo detection. #2788

Conversation

daspecster commented Nov 30, 2016 • edited Loading

dhermes left a comment

Choose a reason for hiding this comment

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

daspecster commented Dec 2, 2016

daspecster commented Dec 2, 2016 • edited Loading

daspecster commented Nov 30, 2016 •

edited

Loading

daspecster commented Dec 2, 2016 •

edited

Loading