Expect vision response data to have missing keys. #2761
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dhermes
reviewed
Nov 21, 2016
| @@ -36,8 +36,9 @@ def from_api_repr(cls, response): | |||
| :rtype: :class:`~google.cloud.vision.color.ImagePropertiesAnnotation`. | |||
| :returns: Populated instance of ``ImagePropertiesAnnotation``. | |||
| """ | |||
| colors = [ColorInformation.from_api_repr(color) for color in | |||
| response['dominantColors']['colors']] | |||
| raw_colors = response.get('dominantColors', {}).get('colors', []) | |||
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
| @@ -61,12 +61,12 @@ def from_api_repr(cls, response): | |||
| :returns: Instance of ``EntityAnnotation``. | |||
| """ | |||
| bounds = Bounds.from_api_repr(response.get('boundingPoly')) | |||
| description = response['description'] | |||
| locale = response.get('locale', None) | |||
| description = response.get('description') | |||
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
| @@ -91,11 +91,13 @@ def from_api_repr(cls, response): | |||
| :rtype: :class:`~google.cloud.vision.face.Emotions` | |||
| :returns: Populated instance of `Emotions`. | |||
| """ | |||
| joy_likelihood = getattr(Likelihood, response['joyLikelihood']) | |||
| sorrow_likelihood = getattr(Likelihood, response['sorrowLikelihood']) | |||
| joy_likelihood = getattr(Likelihood, response.get('joyLikelihood')) | |||
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
| class TestColorInformation(unittest.TestCase): | ||
| @staticmethod | ||
| def _get_target_class(): | ||
| from google.cloud.vision.color import Color |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
|
OK, yeah I have trust issues after learning more about how protubuf treats 0 and null values. But yeah, later time. |
dhermes
approved these changes
Nov 21, 2016
| return Color | ||
|
|
||
| def test_rgb_color_data(self): | ||
| COLORS = { |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
8d79e62 to
fe85e0a
Compare
fe85e0a to
ddc30eb
Compare
richkadel
pushed a commit
to richkadel/google-cloud-python
that referenced
this pull request
May 6, 2017
…y-values Expect vision response data to have missing keys.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2757
I didn't add tests for the other classes, but I can if needed. Honestly, I'm not sure if and when to count on the data being there so my strategy was to try and default to
None.