Explicitly passing a channel to GAPIC-generated API classes #2682
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
If you just wait for the next release of gax you can just pass credentials instead of creating a channel. |
This over-rides the default behavior within GAX, which uses application default credentials.
|
As discussed earlier today, a release of GAX may take too long to wait, but I look forward to deleting this code. |
theacodes
approved these changes
Nov 4, 2016
daspecster
added a commit
to daspecster/google-cloud-python
that referenced
this pull request
Nov 4, 2016
richkadel
pushed a commit
to richkadel/google-cloud-python
that referenced
this pull request
May 6, 2017
Explicitly passing a channel to GAPIC-generated API classes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2631. @jonparrott I'm not sure if your work makes this a temporary fix or a permanent one?
Also, some of these unit tests I just edited definitely made me shudder ¯\_(ツ)_/¯
/cc @bjwatson