Replace types string with str. #2579

tswast · 2016-10-20T22:54:29Z

Based on this comment: #2485 (comment)

For rtypes, used the command:

ag -l 'rtype: string' | xargs sed -i .bak 's/rtype: string/rtype: str/g'

For types, used the command:

ag -l 'type ([^:]+): string' | \
    xargs gsed -r -i.bak -e 's/type ([^:]+): string/type \1: str/g'

Note: -r for gsed (GNU sed) is needed for group matching.

Used the command: ag -l 'rtype: string' | xargs sed -i .bak 's/rtype: string/rtype: str/g' Based on this comment: googleapis#2485 (comment) `str` is a type, `string` is a module.

Uses command: ag -l 'type ([^:]+): string' | \ xargs gsed -r -i.bak -e 's/type ([^:]+): string/type \1: str/g' Note: [-r for gsed (GNU sed) is needed for group matching](http://superuser.com/a/336819/125262).

theacodes · 2016-10-20T22:55:59Z

😆

bigquery/google/cloud/bigquery/dataset.py

@@ -168,7 +168,7 @@ def created(self):
    def dataset_id(self):
        """ID for the dataset resource.

-        :rtype: string, or ``NoneType``
+        :rtype: str, or ``NoneType``


Uses the command: ag -l 'type ([^:]+): boolean' | \ xargs gsed -r -i.bak -e 's/type ([^:]+): boolean/type \1: bool/g'

dhermes

I actually reviewed every line. Why? Because I'm crazy.

LGTM

(I think it'll be hilarious if Travis / Sphinx barfs on this.)

Uses the command: ag -l 'rtype: boolean' | xargs sed -i .bak 's/rtype: boolean/rtype: bool/g'

tswast · 2016-10-20T23:05:45Z

Thanks. For reviewing. I just added some commits for boolean -> bool, too, based on #2485 (comment)

dhermes · 2016-10-20T23:06:53Z

Thanks. For reviewing. I just added some commits for boolean -> bool, too

GAH! Next time, please "heads up new code" first, then push to the PR. (Since review already finished.) Preference: send two PRs.

dhermes · 2016-10-20T23:09:05Z

@tswast bool stuff looks good too. Ping me (or @jonparrott) when Travis is green?

tswast · 2016-10-20T23:09:35Z

Works for me. (Two PRs next time and pinging for Travis)

Replace types string with str.

tswast added 2 commits October 20, 2016 15:34

Replace string with str in rtypes.

01b494c

Used the command: ag -l 'rtype: string' | xargs sed -i .bak 's/rtype: string/rtype: str/g' Based on this comment: googleapis#2485 (comment) `str` is a type, `string` is a module.

Replace types string with str.

60862d1

Uses command: ag -l 'type ([^:]+): string' | \ xargs gsed -r -i.bak -e 's/type ([^:]+): string/type \1: str/g' Note: [-r for gsed (GNU sed) is needed for group matching](http://superuser.com/a/336819/125262).

tswast assigned theacodes and dhermes Oct 20, 2016

googlebot added the cla: yes This human has signed the Contributor License Agreement. label Oct 20, 2016

theacodes approved these changes Oct 20, 2016

View reviewed changes

dhermes reviewed Oct 20, 2016

View reviewed changes

Replace types boolean with bool.

c5ded2a

Uses the command: ag -l 'type ([^:]+): boolean' | \ xargs gsed -r -i.bak -e 's/type ([^:]+): boolean/type \1: bool/g'

dhermes approved these changes Oct 20, 2016

View reviewed changes

Replace rtypes boolean with bool.

7b18887

Uses the command: ag -l 'rtype: boolean' | xargs sed -i .bak 's/rtype: boolean/rtype: bool/g'

tswast mentioned this pull request Oct 20, 2016

Replaces integer with int in types and rtypes. #2580

Merged

dhermes merged commit 22941e2 into googleapis:master Oct 21, 2016

tswast deleted the str-not-string branch October 21, 2016 16:07

richkadel pushed a commit to richkadel/google-cloud-python that referenced this pull request May 6, 2017

Merge pull request googleapis#2579 from tswast/str-not-string

57861ed

Replace types string with str.

theacodes unassigned dhermes Sep 28, 2018

parthea pushed a commit that referenced this pull request Jun 4, 2023

Merge pull request #2579 from tswast/str-not-string

3fcb1d4

Replace types string with str.

parthea pushed a commit that referenced this pull request Oct 21, 2023

Merge pull request #2579 from tswast/str-not-string

b2d6a2c

Replace types string with str.

parthea pushed a commit that referenced this pull request Oct 21, 2023

Merge pull request #2579 from tswast/str-not-string

9827ade

Replace types string with str.

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Replace types string with str. #2579

Replace types string with str. #2579

tswast commented Oct 20, 2016

theacodes commented Oct 20, 2016

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

dhermes left a comment

tswast commented Oct 20, 2016

dhermes commented Oct 20, 2016

dhermes commented Oct 20, 2016

tswast commented Oct 20, 2016

Replace types string with str. #2579

Replace types string with str. #2579

Conversation

tswast commented Oct 20, 2016

theacodes commented Oct 20, 2016

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

dhermes left a comment

Choose a reason for hiding this comment

tswast commented Oct 20, 2016

dhermes commented Oct 20, 2016

dhermes commented Oct 20, 2016

tswast commented Oct 20, 2016