-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support parsing DATE columns from Standard SQL tables #2265
Conversation
5ce1578
to
dfdad0e
Compare
... guess I couldn't quite figure out how to unit test the _date_from_json as I couldn't find where the other _X_from_json functions were tested |
Tests for the |
Thanks for the patch, BTW! |
@tseaver Ty, I did find the tests module, but as the function I added had several similar functions I wanted to test it consistently, and I guess I couldn't find the tests for the others; Ex. I added _date_from_json and "_float_from_json" already existed hence I want to test it in the same manner, but can't see where that happens |
@thejens Hmmm, I see what you mean. Those helpers are being covered indirectly through the tests for |
Change-Id: I20a6fff4362e27ee35286a3538c24e37bc858faf
@tseaver Thanks for putting those tests there; seems they and the one I added passed |
@thejens Thanks again! |
Change-Id: I158b48b6470ff44ff006e18d5eb8e3540749670b