Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support parsing DATE columns from Standard SQL tables #2265

Merged
merged 1 commit into from
Sep 9, 2016

Conversation

thejens
Copy link

@thejens thejens commented Sep 8, 2016

Change-Id: I158b48b6470ff44ff006e18d5eb8e3540749670b

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Sep 8, 2016
@thejens thejens force-pushed the master branch 2 times, most recently from 5ce1578 to dfdad0e Compare September 8, 2016 11:56
@thejens
Copy link
Author

thejens commented Sep 8, 2016

... guess I couldn't quite figure out how to unit test the _date_from_json as I couldn't find where the other _X_from_json functions were tested

@tseaver
Copy link
Contributor

tseaver commented Sep 8, 2016

Tests for the bigquery._helpers module are here.

@tseaver
Copy link
Contributor

tseaver commented Sep 8, 2016

Thanks for the patch, BTW!

@thejens
Copy link
Author

thejens commented Sep 8, 2016

@tseaver Ty, I did find the tests module, but as the function I added had several similar functions I wanted to test it consistently, and I guess I couldn't find the tests for the others;

Ex. I added _date_from_json and "_float_from_json" already existed hence I want to test it in the same manner, but can't see where that happens

@tseaver
Copy link
Contributor

tseaver commented Sep 8, 2016

@thejens Hmmm, I see what you mean. Those helpers are being covered indirectly through the tests for query and table. They should probably have their own coverage in test__helpers.py, though.

@daspecster daspecster added the api: bigquery Issues related to the BigQuery API. label Sep 8, 2016
@tseaver
Copy link
Contributor

tseaver commented Sep 8, 2016

@thejens I landed more comprehensive tests for google.cloud.bigquery._helpers in #2272. They should serve as a model for your tests of _date_from_json.

Change-Id: I20a6fff4362e27ee35286a3538c24e37bc858faf
@thejens
Copy link
Author

thejens commented Sep 9, 2016

@tseaver Thanks for putting those tests there; seems they and the one I added passed

@tseaver tseaver merged commit 298b28a into googleapis:master Sep 9, 2016
@tseaver
Copy link
Contributor

tseaver commented Sep 9, 2016

@thejens Thanks again!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: bigquery Issues related to the BigQuery API. cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants