Fix monitoring documentation TOC. #2247
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| }, | ||
| { | ||
| "title": "Time Series Query", | ||
| "type": "gcloud/monitoring/index/query" | ||
| "type": "gcloud/monitoring/query/query" |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
|
@daspecster Let's once and for all write a script for generating this JSON. Hand-crafted JSON is just a bad idea. If we want custom edits, we'll write them in Python and make the script toss them into the autogenerated dictionary. |
|
LGTM |
|
@dhermes yeah, I've started doing this in a branch for another issue. I'll just go full tilt on this for the TOC. I should have a PR for it today. |
It should be a standalone anyhow |
|
Yeah, I was thinking of just making the toc a python dict? How does that sound for the first PR? |
|
It doesn't amount to any actual change. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Partial resolution for #2246.
The table of contents references were wrong.