Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove some unused features of gcloud.streaming. #2240

Merged
merged 1 commit into from
Sep 2, 2016
Merged

Remove some unused features of gcloud.streaming. #2240

merged 1 commit into from
Sep 2, 2016

Conversation

dhermes
Copy link
Contributor

@dhermes dhermes commented Sep 2, 2016

Towards #1998.

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Sep 2, 2016
@daspecster
Copy link
Contributor

The idea is just moving the usage of httplib2 upward since get_http doesn't really get used?

@dhermes
Copy link
Contributor Author

dhermes commented Sep 2, 2016

No we want to get a full-on divorce from httplib2. gcloud.streaming is huge and I'm just sifting through it right now trying to figure out what the core parts are. So along the way I realized we weren't using these features.

@daspecster
Copy link
Contributor

LGTM pending travis.

@dhermes dhermes merged commit f1ffbfd into googleapis:master Sep 2, 2016
@dhermes dhermes deleted the remove-some-streaming-yagni branch September 2, 2016 21:05
@dhermes dhermes mentioned this pull request Sep 19, 2016
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@tseaver tseaver

Labels
api: core cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@dhermes @daspecster @tseaver @googlebot