Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Omit 'schema' as part of 'Table.{create,update}' when 'view_query` is set #1703

Merged
merged 3 commits into from
Apr 8, 2016
Merged

Omit 'schema' as part of 'Table.{create,update}' when 'view_query` is set #1703

merged 3 commits into from
Apr 8, 2016

Conversation

tseaver
Copy link
Contributor

@tseaver tseaver commented Apr 7, 2016

Closes #1701.

@tseaver tseaver added type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns. api: bigquery Issues related to the BigQuery API. labels Apr 7, 2016
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Apr 7, 2016
dhermes
dhermes reviewed Apr 7, 2016
View reviewed changes
gcloud/bigquery/table.py
@@ -419,6 +419,8 @@ def _build_resource(self):
if self.view_query is not None:
view = resource['view'] = {}
view['query'] = self.view_query
# https://github.com/GoogleCloudPlatform/gcloud-python/issues/1701

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

@dhermes
Copy link
Contributor

dhermes commented Apr 7, 2016

Lint errors:

************* Module gcloud.bigquery.test_table
I:1400, 0: Locally disabling too-many-statements (R0915) (locally-disabled)
I:1602, 0: Locally disabling unused-argument (W0613) (locally-disabled)
W:800, 8: Unused variable 'full_name' (unused-variable)
W:801, 8: Unused variable 'age' (unused-variable)

dhermes
dhermes reviewed Apr 7, 2016
View reviewed changes
gcloud/bigquery/table.py
@@ -419,6 +419,8 @@ def _build_resource(self):
if self.view_query is not None:
view = resource['view'] = {}
view['query'] = self.view_query
# Back-end rejects 'schema' when passing a query.
del resource['schema']

This comment was marked as spam.

Sign in to view

@tseaver
Copy link
Contributor Author

tseaver commented Apr 8, 2016

@dhermes Any remaining issue?

@dhermes
Copy link
Contributor

dhermes commented Apr 8, 2016

LGTM. Squash if you have the energy for it.

@tseaver tseaver merged commit ac50331 into googleapis:master Apr 8, 2016
@tseaver tseaver deleted the 1701-bigquery-skip_sending_schema_w_view_query branch April 11, 2016 20:46
tseaver added a commit that referenced this pull request Apr 11, 2016
@tseaver
Merge pull request #1716 from tseaver/1703-fix_coverage_gap
cefff49 
Fix coverage gap introduced in PR #1703.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
api: bigquery Issues related to the BigQuery API. cla: yes This human has signed the Contributor License Agreement. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tseaver @dhermes @googlebot