Adding Bigtable Cluster.from_pb factory. #1235
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| :type property_name: str | ||
| :param property_name: The property value to check against. | ||
|
|
||
| :type value: object or :data:`NoneType <types.NoneType>` |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
For creating a Cluster object from a protobuf cluster returned from the API. Also adding a helper for making sure properties are set on a protobuf object.
48dce46 to
083e738
Compare
|
@tseaver PTAL. I just implemented |
|
LGTM |
dhermes
added a commit
that referenced
this pull request
Nov 20, 2015
Adding Bigtable Cluster.from_pb factory.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For creating a Cluster object from a protobuf cluster returned from the API.
Also adding a helper for making sure properties are set on a protobuf object.