Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(bigquery): adjust test assertions to new default timeout #10222

Merged
merged 1 commit into from
Jan 30, 2020
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 8 additions & 2 deletions bigquery/tests/unit/test__http.py
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,12 @@


class TestConnection(unittest.TestCase):
@staticmethod
def _get_default_timeout():
from google.cloud.bigquery._http import _http

return _http._DEFAULT_TIMEOUT

@staticmethod
def _get_target_class():
from google.cloud.bigquery._http import Connection
Expand Down Expand Up @@ -79,7 +85,7 @@ def test_user_agent(self):
headers=expected_headers,
method="GET",
url=expected_uri,
timeout=None,
timeout=self._get_default_timeout(),
)
self.assertIn("my-application/1.2.3", conn.user_agent)

Expand Down Expand Up @@ -112,5 +118,5 @@ def test_extra_headers_replace(self):
headers=expected_headers,
method="GET",
url=expected_uri,
timeout=None,
timeout=self._get_default_timeout(),
)