Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

KMS: Documentation link on googleapis.dev is missing. #8993

Closed
di opened this issue Aug 8, 2019 · 1 comment · Fixed by #8998
Closed

KMS: Documentation link on googleapis.dev is missing. #8993

di opened this issue Aug 8, 2019 · 1 comment · Fixed by #8998
Assignees
@busunkim96
Labels
api: cloudasset Issues related to the Cloud Asset Inventory API. api: cloudkms Issues related to the Cloud Key Management Service API. api: cloudtasks Issues related to the Cloud Tasks API. api: cloudtrace Issues related to the Cloud Trace API. api: monitoring Issues related to the Cloud Monitoring API. type: docs Improvement to the documentation for an API.

Comments

@di
Copy link
Member

di commented Aug 8, 2019

In #8705 the "Client Library Documentation" link in the google-cloud-kms README was changed from https://googleapis.github.io/google-cloud-python/latest/kms/index.html to https://googleapis.dev/python/kms/latest, but the latter does not exist.

Ref: https://issuetracker.google.com/issues/139095461
@tseaver tseaver changed the title Documentation link for google-cloud-kms is 404 KMS: Documentation link on googleapis.dev is missing. Aug 8, 2019
@tseaver tseaver added api: cloudkms Issues related to the Cloud Key Management Service API. type: docs Improvement to the documentation for an API. api: cloudasset Issues related to the Cloud Asset Inventory API. api: cloudtasks Issues related to the Cloud Tasks API. api: cloudtrace Issues related to the Cloud Trace API. api: monitoring Issues related to the Cloud Monitoring API. api: scheduler labels Aug 8, 2019
@tseaver
Copy link
Contributor

tseaver commented Aug 8, 2019

The following are invalid "client library documentation" URLs linked into READMES:

The one for monitoring hasn't been converted, now fixed in #8994.

@busunkim96 Can you help figure out why the others are broken?

tseaver added a commit that referenced this issue Aug 8, 2019
@tseaver
Normalize docs. (#8994)
adccba0 
* Make 'containeranalysis/docs/README.rst' a symlink.

* DRY 'phishinprotection/docs/index.rst', include changelog.

* Update 'monitoring/README.rst' to use googleapis.dev URL.

See #8993.
@busunkim96 busunkim96 mentioned this issue Aug 8, 2019
Merged
parthea pushed a commit that referenced this issue Jun 4, 2023
@tseaver
Normalize docs. (#8994)
7281c74 
* Make 'containeranalysis/docs/README.rst' a symlink.

* DRY 'phishinprotection/docs/index.rst', include changelog.

* Update 'monitoring/README.rst' to use googleapis.dev URL.

See #8993.
parthea pushed a commit that referenced this issue Oct 21, 2023
@tseaver
Normalize docs. (#8994)
036e498 
* Make 'containeranalysis/docs/README.rst' a symlink.

* DRY 'phishinprotection/docs/index.rst', include changelog.

* Update 'monitoring/README.rst' to use googleapis.dev URL.

See #8993.
parthea pushed a commit that referenced this issue Oct 21, 2023
@tseaver
Normalize docs. (#8994)
068c66e 
* Make 'containeranalysis/docs/README.rst' a symlink.

* DRY 'phishinprotection/docs/index.rst', include changelog.

* Update 'monitoring/README.rst' to use googleapis.dev URL.

See #8993.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@busunkim96 busunkim96

Labels
api: cloudasset Issues related to the Cloud Asset Inventory API. api: cloudkms Issues related to the Cloud Key Management Service API. api: cloudtasks Issues related to the Cloud Tasks API. api: cloudtrace Issues related to the Cloud Trace API. api: monitoring Issues related to the Cloud Monitoring API. type: docs Improvement to the documentation for an API.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Docs: Fix links to googleapis.dev busunkim96/google-cloud-python
3 participants
@tseaver @di @busunkim96