Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

STORAGE: In _reload_properties, should we raise if _changes is not empty? #729

Closed
dhermes opened this issue Mar 13, 2015 · 3 comments
Closed
Assignees
Labels
api: storage Issues related to the Cloud Storage API. priority: p2 Moderately-important priority. Fix may not be included in next release. type: question Request for information or clarification. Not an issue.

Comments

@dhermes
Copy link
Contributor

dhermes commented Mar 13, 2015

No description provided.

@dhermes dhermes added the api: storage Issues related to the Cloud Storage API. label Mar 13, 2015
@dhermes dhermes added this to the Storage Stable milestone Mar 13, 2015
@tseaver tseaver added the type: question Request for information or clarification. Not an issue. label Nov 10, 2015
@tseaver
Copy link
Contributor

tseaver commented Nov 10, 2015

👎 Logging a warning might be appropriate, but if the user has triggered an API call (the only public way to reach _reload_properties), the server-side version of the metadata is always authoritative.

@lukesneeringer lukesneeringer added the priority: p2 Moderately-important priority. Fix may not be included in next release. label Apr 19, 2017
@tseaver
Copy link
Contributor

tseaver commented Jun 5, 2017

I'm uncertain why we would assign a priority to this, or slot it into a project, given that it is an open question (not a bug, not a requested enhancement).

@lukesneeringer
Copy link
Contributor

Hello,
One of the challenges of maintaining a large open source project is that sometimes, you can bite off more than you can chew. As the lead maintainer of google-cloud-python, I can definitely say that I have let the issues here pile up.

As part of trying to get things under control (as well as to empower us to provide better customer service in the future), I am declaring a "bankruptcy" of sorts on many of the old issues, especially those likely to have been addressed or made obsolete by more recent updates.

My goal is to close stale issues whose relevance or solution is no longer immediately evident, and which appear to be of lower importance. I believe in good faith that this is one of those issues, but I am scanning quickly and may occasionally be wrong. If this is an issue of high importance, please comment here and we will reconsider. If this is an issue whose solution is trivial, please consider providing a pull request.

Thank you!

parthea pushed a commit that referenced this issue Oct 21, 2023
- [ ] Regenerate this pull request now.

Source-Link: googleapis/googleapis@63c3007

Source-Link: googleapis/googleapis-gen@b658223
Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiYjY1ODIyMzFhZTdiN2Y1Y2QxOGY3ZDE0MmM2NTQyMTc3M2NjYTVkZSJ9

PiperOrigin-RevId: 474313212

Source-Link: googleapis/googleapis@cec7333

Source-Link: googleapis/googleapis-gen@47afba9
Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiNDdhZmJhOWQzNmI4NGNiYmFhODVkNmUzYmMzNGVmNjVlZmU2MjRlZSJ9

fix(deps): require google-api-core>=2.10.1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: storage Issues related to the Cloud Storage API. priority: p2 Moderately-important priority. Fix may not be included in next release. type: question Request for information or clarification. Not an issue.
Projects
None yet
Development

No branches or pull requests

3 participants