Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove Query dependency on Dataset and make dataset_id required in Query #485

Closed
dhermes opened this issue Jan 3, 2015 · 1 comment · Fixed by #498
Closed

Remove Query dependency on Dataset and make dataset_id required in Query #485

dhermes opened this issue Jan 3, 2015 · 1 comment · Fixed by #498
Assignees
@tseaver
Labels
api: datastore Issues related to the Datastore API. 🚨 This issue needs some love. triage me I really want to be triaged.

Comments

@dhermes
Copy link
Contributor

dhermes commented Jan 3, 2015

Use dataset_id instead and allow connection as optional argument on methods which interact with the network.

Need to finish #478 before this is possible to do in a user-friendly way.
@dhermes dhermes added the api: datastore Issues related to the Datastore API. label Jan 3, 2015
@dhermes dhermes mentioned this issue Jan 3, 2015
Closed
9 tasks
@dhermes dhermes changed the title Remove Query dependency on Dataset Remove Query dependency on Dataset and make dataset_id required in Query Jan 3, 2015
This was referenced Jan 6, 2015
Merged
Merged
@tseaver tseaver self-assigned this Jan 6, 2015
@dhermes dhermes mentioned this issue Jan 6, 2015
Closed
@tseaver tseaver mentioned this issue Jan 7, 2015
Merged
@tseaver
Copy link
Contributor

tseaver commented Jan 7, 2015

We should be able to fall back to the "implicit" dataset ID, if none is passed to Query.__init__ (post #493).

This was referenced Jan 7, 2015
Merged
Merged
tseaver added a commit that referenced this issue Jan 7, 2015
@tseaver
Merge pull request #498 from tseaver/485-remove_dataset_obj_from_query
9bafba0 
#485: Drop Query use of Dataset object
@jgeewax jgeewax modified the milestone: Datastore Stable Jan 30, 2015
@yoshi-automation yoshi-automation added 🚨 This issue needs some love. triage me I really want to be triaged. labels Apr 7, 2020
atulep pushed a commit that referenced this issue Apr 6, 2023
@renovate-bot
chore(deps): update dependency google-cloud-speech to v2.17.1 (#485)
9207ce5
atulep pushed a commit that referenced this issue Apr 6, 2023
@renovate-bot
chore(deps): update dependency google-cloud-speech to v2.17.1 (#485)
f1d0217
atulep pushed a commit that referenced this issue Apr 18, 2023
@renovate-bot
chore(deps): update dependency google-cloud-speech to v2.17.1 (#485)
90e99b0
parthea pushed a commit that referenced this issue Aug 15, 2023
@gcf-owl-bot
feat(v3beta1): ResponseMessage proto contains channel information (#485)
8cc8b58 
* feat: ResponseMessage proto contains channel information
docs: updated go library package

PiperOrigin-RevId: 501339595

Source-Link: googleapis/googleapis@a3f5e24

Source-Link: googleapis/googleapis-gen@03226f2
Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiMDMyMjZmMmMzYWQ3NDJhOTYxNTg2NTY5NDU1NjgxNGYzOWZkNjU2ZSJ9

* 🦉 Updates from OwlBot post-processor

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
parthea pushed a commit that referenced this issue Sep 22, 2023
@renovate-bot
chore(deps): update dependency google-cloud-pubsub to v2.18.1 (#485)
5a9c6d6
parthea pushed a commit that referenced this issue Sep 22, 2023
@gcf-owl-bot
chore: updated docs and code sturcture for Dataproc metric configurat…
b16c12e 
…ion (#485)

* chore: updated docs and code sturcture for Dataproc metric configuration

Committer: @akshatbhargava123
PiperOrigin-RevId: 477101789

Source-Link: googleapis/googleapis@2e19de1

Source-Link: googleapis/googleapis-gen@c12032a
Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiYzEyMDMyYTU5Nzc4ZmRkMTczZDRjZmU4MmM0NzJjMDU5NjA0Mzg2NSJ9

* 🦉 Updates from OwlBot post-processor

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
parthea pushed a commit that referenced this issue Sep 22, 2023
@renovate-bot
chore(deps): update dependency google-cloud-bigquery to v3.5.0 (#485)
20de040
parthea pushed a commit that referenced this issue Oct 21, 2023
@gcf-owl-bot
chore: fix path to requirements.txt in release script [autoapprove] (#…
1a79ee5 
…485)

Source-Link: googleapis/synthtool@fdba3ed
Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:1f0dbd02745fb7cf255563dab5968345989308544e52b7f460deadd5e78e63b0
parthea pushed a commit that referenced this issue Oct 21, 2023
@gcf-owl-bot
chore(python): update .kokoro/requirements.txt (#485)
a310794 
Source-Link: googleapis/synthtool@703554a
Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:94961fdc5c9ca6d13530a6a414a49d2f607203168215d074cdb0a1df9ec31c0b
parthea pushed a commit that referenced this issue Oct 21, 2023
@release-please
chore(main): release 3.11.0 (#485)
965912d 
Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
parthea pushed a commit that referenced this issue Oct 21, 2023
@gcf-owl-bot
docs: update comments for image annotator OCR models (#485)
b9010e7 
* docs: update comments for image annotator OCR models

PiperOrigin-RevId: 474070246

Source-Link: googleapis/googleapis@346e2f2

Source-Link: googleapis/googleapis-gen@50b3451
Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiNTBiMzQ1MTVmYTg5NTI1OTg5MDIxYmU0YjY5ODlkNDkwNTlkOGQyNiJ9

* 🦉 Updates from OwlBot post-processor

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
parthea pushed a commit that referenced this issue Oct 22, 2023
@renovate-bot
chore(deps): update dependency google-cloud-speech to v2.17.1 (#485)
ca5ff04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tseaver tseaver

Labels
api: datastore Issues related to the Datastore API. 🚨 This issue needs some love. triage me I really want to be triaged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

#485: Drop Query use of Dataset object
4 participants
@jgeewax @tseaver @dhermes @yoshi-automation