Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Collect object / bucket updates in batch #351

Closed
dhermes opened this issue Nov 6, 2014 · 4 comments
Closed

Collect object / bucket updates in batch #351

dhermes opened this issue Nov 6, 2014 · 4 comments
Assignees
@tseaver
Labels
api: datastore Issues related to the Datastore API. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.

Comments

@dhermes
Copy link
Contributor

dhermes commented Nov 6, 2014

See
https://github.com/GoogleCloudPlatform/gcloud-python/pull/349/files#r19983607

By sending a PATCH request every time a property is set, we may make an application unnecessarily slow. We should work to make this simple and intuitive to users.
@dhermes dhermes added type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design. api: datastore Issues related to the Datastore API. labels Nov 6, 2014
@dhermes dhermes mentioned this issue Nov 6, 2014
Merged
@tseaver
Copy link
Contributor

tseaver commented Nov 6, 2014

I think "simple/intuitive" and "performant" are probably contradictory goals: distributed systems are hard.

@dhermes
Copy link
Contributor Author

dhermes commented Nov 6, 2014

Sorry, I was just trying to throw this together quickly mid-review. Main thrust is just that we should consider batching.

@tseaver
Copy link
Contributor

tseaver commented Nov 7, 2014

I didn't mean to sling stones: just noting that it is tricky to find a balance.

@tseaver tseaver mentioned this issue Nov 7, 2014
Merged
@tseaver
Copy link
Contributor

tseaver commented Nov 7, 2014

#352 adds a quasi-transactional batch attribute, which can be used as a context manager to group multiple updates.

@tseaver tseaver closed this as completed in 8536991 Nov 7, 2014
@jgeewax jgeewax modified the milestone: Datastore Stable Jan 30, 2015
atulep pushed a commit that referenced this issue Apr 3, 2023
@busunkim96 @parthea
chore: allow releases from previous major versions (#351)
0892d03 
Co-authored-by: Anthonios Partheniou <partheniou@google.com>
atulep pushed a commit that referenced this issue Apr 6, 2023
@busunkim96 @parthea
chore: allow releases from previous major versions (#351)
ebeb9ab 
Co-authored-by: Anthonios Partheniou <partheniou@google.com>
atulep pushed a commit that referenced this issue Apr 6, 2023
@busunkim96 @parthea
chore: allow releases from previous major versions (#351)
322e00c 
Co-authored-by: Anthonios Partheniou <partheniou@google.com>
atulep pushed a commit that referenced this issue Apr 18, 2023
@busunkim96 @parthea
chore: allow releases from previous major versions (#351)
c885c83 
Co-authored-by: Anthonios Partheniou <partheniou@google.com>
parthea pushed a commit that referenced this issue Jun 4, 2023
@gcf-owl-bot
chore(python): allow client documentation to be customized in README (#…
16ac8a2 
…351)

Source-Link: googleapis/synthtool@95d9289
Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:c8878270182edaab99f2927969d4f700c3af265accd472c3425deedff2b7fd93

Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
parthea pushed a commit that referenced this issue Jun 4, 2023
@release-please
chore(main): release 1.12.0 (#351)
72876df 
Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
parthea pushed a commit that referenced this issue Jun 4, 2023
@gcf-owl-bot
chore(python): auto approve template changes (#351)
a4b6566 
Source-Link: googleapis/synthtool@453a5d9
Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:81ed5ecdfc7cac5b699ba4537376f3563f6f04122c4ec9e735d3b3dc1d43dd32

Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
parthea pushed a commit that referenced this issue Jun 4, 2023
@gcf-owl-bot
chore(python): update .kokoro/requirements.txt (#351)
29158a4 
Source-Link: googleapis/synthtool@703554a
Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:94961fdc5c9ca6d13530a6a414a49d2f607203168215d074cdb0a1df9ec31c0b

Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
parthea pushed a commit that referenced this issue Sep 20, 2023
@renovate-bot
chore(deps): update dependency google-cloud-bigquery to v3.3.3 (#351)
8bd056f
vchudnov-g pushed a commit that referenced this issue Sep 20, 2023
@slowy07
chore: code clean up (#351)
81c403c 
Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:
- [x] Make sure to open an issue as a [bug/issue](https://github.com/googleapis/python-dialogflow/issues/new/choose) before writing your code!  That way we can discuss the change, evaluate designs, and agree on the general idea
- [x] Ensure the tests and linter pass
- [x] Code coverage does not decrease (if any source code was changed)
- [x] Appropriate docs were updated (if necessary)

Fixes #350  🦕
parthea added a commit that referenced this issue Sep 22, 2023
@release-please @parthea
chore(main): release 3.6.2 (#351)
02a9b4b 
Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
Co-authored-by: Anthonios Partheniou <partheniou@google.com>
parthea pushed a commit that referenced this issue Sep 22, 2023
@renovate-bot
chore(deps): update dependency google-cloud-bigquery-reservation to v…
3c52da2 
…1.11.1 (#351)
parthea pushed a commit that referenced this issue Sep 22, 2023
@gcf-owl-bot
docs: minor grammar improvements (#351)
b24e981 
* docs: minor grammar improvements

PiperOrigin-RevId: 511850615

Source-Link: googleapis/googleapis@6f90843

Source-Link: googleapis/googleapis-gen@26bf8b2
Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiMjZiZjhiMmFmNjI3NmNhMzRjYTZjNTNlYjQ0MTBmMWUyNGE4ZjZmYSJ9

* 🦉 Updates from OwlBot post-processor

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

* chore: Update gapic-generator-python to v1.8.5

PiperOrigin-RevId: 511892190

Source-Link: googleapis/googleapis@a45d9c0

Source-Link: googleapis/googleapis-gen@1907294
Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiMTkwNzI5NGIxZDgzNjVlYTI0ZjhjNWYyZTA1OWE2NDEyNGM0ZWQzYiJ9

* 🦉 Updates from OwlBot post-processor

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

* docs: minor grammar improvements

PiperOrigin-RevId: 512664562

Source-Link: googleapis/googleapis@2328fdb

Source-Link: googleapis/googleapis-gen@9363531
Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiOTM2MzUzMTVlYjdmYjBkOTlhNWI2MDRkMTgxMDZiOGY0NzI3NTRiMiJ9

* 🦉 Updates from OwlBot post-processor

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

---------

Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
parthea pushed a commit that referenced this issue Sep 22, 2023
@renovate-bot
chore(deps): update all dependencies (#351)
428d803
parthea pushed a commit that referenced this issue Sep 22, 2023
@gcf-owl-bot
build: [autoapprove] bump cryptography from 41.0.2 to 41.0.3 (#351)
556fc96 
Source-Link: https://togithub.com/googleapis/synthtool/commit/352b9d4c068ce7c05908172af128b294073bf53c
Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:3e3800bb100af5d7f9e810d48212b37812c1856d20ffeafb99ebe66461b61fc7
parthea pushed a commit that referenced this issue Sep 22, 2023
@gcf-owl-bot
fix: Add async context manager return types (#351)
4c1074f 
* fix: Add async context manager return types

chore: Mock return_value should not populate oneof message fields

chore: Support snippet generation for services that only support REST transport

chore: Update gapic-generator-python to v1.11.0
PiperOrigin-RevId: 545430278

Source-Link: googleapis/googleapis@601b532

Source-Link: googleapis/googleapis-gen@b3f18d0
Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiYjNmMThkMGY2NTYwYTg1NTAyMmZkMDU4ODY1ZTc2MjA0NzlkN2FmOSJ9

* 🦉 Updates from OwlBot post-processor

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

---------

Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
parthea added a commit that referenced this issue Sep 22, 2023
@parthea
fix(deps): allow protobuf < 5.0.0 (#351)
6157188 
* fix(deps): allow protobuf < 5.0.0\nfix(deps): require proto-plus >= 1.22.0

* fix(deps): require proto-plus >= 1.22.0

* update constraints
parthea pushed a commit that referenced this issue Oct 21, 2023
@gcf-owl-bot
chore(samples): Add check for tests in directory (#351)
4dfb5ba 
Source-Link: googleapis/synthtool@52aef91
Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:36a95b8f494e4674dc9eee9af98961293b51b86b3649942aac800ae6c1f796d4

Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
parthea added a commit that referenced this issue Oct 21, 2023
@parthea
fix(deps): allow protobuf 3.19.5 (#351)
3aac93a 
fix(deps): require google-api-core >=2.10.2
parthea pushed a commit that referenced this issue Oct 21, 2023
@gcf-owl-bot
build(deps): bump certifi from 2022.9.24 to 2022.12.7 in /synthtool/g…
3f3d30b 
…cp/templates/python_library/.kokoro (#351)

Source-Link: googleapis/synthtool@b4fe62e
Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:3bf87e47c2173d7eed42714589dc4da2c07c3268610f1e47f8e1a30decbfc7f1

Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
parthea pushed a commit that referenced this issue Oct 21, 2023
@release-please
chore(main): release 2.12.3 (#351)
95b34a0 
Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
parthea pushed a commit that referenced this issue Oct 21, 2023
@gcf-owl-bot
chore(deps): update actions/download-artifact action to v3 (#351)
7d3073e 
Source-Link: googleapis/synthtool@38e11ad
Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:4e1991042fe54b991db9ca17c8fb386e61b22fe4d1472a568bf0fcac85dcf5d3
parthea pushed a commit that referenced this issue Oct 21, 2023
@renovate-bot
chore(deps): update dependency backoff to v2 (#351)
8367186
parthea pushed a commit that referenced this issue Oct 21, 2023
@release-please
chore(main): release 0.18.0 (#351)
b983487 
Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
parthea pushed a commit that referenced this issue Oct 21, 2023
@renovate-bot
chore(deps): update dependency pytest to v7.3.0 (#351)
5bbd8eb
parthea pushed a commit that referenced this issue Oct 21, 2023
@gcf-owl-bot
chore(deps): update actions/download-artifact action to v3 (#351)
404cb75 
Source-Link: googleapis/synthtool@38e11ad
Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:4e1991042fe54b991db9ca17c8fb386e61b22fe4d1472a568bf0fcac85dcf5d3
parthea pushed a commit that referenced this issue Oct 21, 2023
@gcf-owl-bot
feat: Add allow_failure, exit_code, and allow_exit_code to BuildStep …
3fb9527 
…message (#351)

* feat: Add allow_failure, exit_code, and allow_exit_code to BuildStep message

Committer: @arvinddayal
PiperOrigin-RevId: 484308212

Source-Link: googleapis/googleapis@bc84ad5

Source-Link: googleapis/googleapis-gen@c6550a6
Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiYzY1NTBhNjZlZmU3NTk1ODMyNDczZWZlNTFhNThkZGQwYTA1YzJkOCJ9

* 🦉 Updates from OwlBot post-processor

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
parthea added a commit that referenced this issue Oct 22, 2023
@busunkim96 @parthea
chore: allow releases from previous major versions (#351)
2ca76a0 
Co-authored-by: Anthonios Partheniou <partheniou@google.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tseaver tseaver

Labels
api: datastore Issues related to the Datastore API. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@jgeewax @tseaver @dhermes