Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should system tests be parametrized to run under both HTTP and gRPC? #3403

Closed
waprin opened this issue May 11, 2017 · 3 comments
Closed

Should system tests be parametrized to run under both HTTP and gRPC? #3403

waprin opened this issue May 11, 2017 · 3 comments
Labels
type: question Request for information or clarification. Not an issue.

Comments

@waprin
Copy link
Contributor

waprin commented May 11, 2017

Some google-cloud-* libraries have both gRPC (gax) transports and HTTP transports. Logging, Datastore, Error Reporting, Pub/Sub at least. The clients generally try to use gRPC unless there's an ImportError (no gRPC support) ,or it's explicitly disabled by google.cloud.environment_vars.DISABLE_GRPC or a constructor argument to the client.

As far as I can tell most system tests just instantiate a client, so the tests only use one of these transports. On the CI systems gRPC is supported and so I think the HTTP paths are less tested.

@jonparrott asked about this in #3386, it seemed a reasonable thing to give some thought to, so just wanted to create a discussion tracking issue.

I think this would be somewhat straightforward to do with nox, so main question is probably whether it's worth doing. Making the CI build slower is probably the biggest negative.

@waprin waprin added the type: question Request for information or clarification. Not an issue. label May 11, 2017
@dhermes
Copy link
Contributor

dhermes commented May 11, 2017

Yes they should, but on a cron basis.

@dhermes
Copy link
Contributor

dhermes commented May 11, 2017

@waprin #2658 already exists. Shall we close this one or that one?

@waprin
Copy link
Contributor Author

waprin commented May 11, 2017

Ah sorry, didn't search enough.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: question Request for information or clarification. Not an issue.
Projects
None yet
Development

No branches or pull requests

2 participants