Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create new repo for test_utils #10327

Closed
busunkim96 opened this issue Feb 4, 2020 · 6 comments
Closed

Create new repo for test_utils #10327

busunkim96 opened this issue Feb 4, 2020 · 6 comments
Assignees
Labels
type: cleanup An internal cleanup or hygiene concern.

Comments

@busunkim96
Copy link
Contributor

Libraries can no longer install test_utils from a shared library once they are in a split repo.

Create a new repository for test_utils, and modify noxfiles to install test_utils from the git repo directly.

@busunkim96 busunkim96 added the type: cleanup An internal cleanup or hygiene concern. label Feb 4, 2020
@danoscarmike
Copy link
Contributor

@busunkim96 I see that there is a repo created at: https://github.com/googleapis/python-test-utils. Is it the intention to put a common set of utilities in there so that we don't have them duplicated across every api repo?

@busunkim96
Copy link
Contributor Author

@danoscarmike Yep! I temporarily copied the test_utils directory into every library that needs it, but it should ideally be installed from one place.

@tmatsuo
Copy link
Contributor

tmatsuo commented Apr 7, 2020

@danoscarmike
Copy link
Contributor

Thanks both. Are test_utils used outside of googleapis org?

@danoscarmike
Copy link
Contributor

danoscarmike commented Apr 8, 2020

I was thinking the following as next steps:

  • Merge files to python-test-utils master
  • Update synthtool noxfile template
  • Update each existing client’s noxfile (example: python-asset) to use the common repo
  • Remove /test_utils sub-directory from each client repo

danoscarmike added a commit to danoscarmike/python-asset that referenced this issue Apr 13, 2020
danoscarmike added a commit to googleapis/python-asset that referenced this issue Apr 14, 2020
* chore: installs test_utils from common repo
* fix: indentation, link errors
* fix: pins sphinx<3.0.0

Refer googleapis/google-cloud-python#10327
@plamut
Copy link
Contributor

plamut commented Apr 30, 2020

Can this be closed now?

I can see that the new test utils repo now exists (thanks!), and some of the libraries already used it. I also already opened PRs in BigQuery and PubSub to clean the test_utils directory, and tracked that in their respective repos.

There is probably a better chance that library maintainers will see this if we open cleanup tickets in the library repos directly?

parthea pushed a commit that referenced this issue Oct 21, 2023
* chore: installs test_utils from common repo
* fix: indentation, link errors
* fix: pins sphinx<3.0.0

Refer #10327
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: cleanup An internal cleanup or hygiene concern.
Projects
None yet
Development

No branches or pull requests

4 participants