-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create new repo for test_utils #10327
Comments
@busunkim96 I see that there is a repo created at: https://github.com/googleapis/python-test-utils. Is it the intention to put a common set of utilities in there so that we don't have them duplicated across every api repo? |
@danoscarmike Yep! I temporarily copied the test_utils directory into every library that needs it, but it should ideally be installed from one place. |
How about to re-use https://github.com/GoogleCloudPlatform/python-repo-tools ? |
Thanks both. Are test_utils used outside of googleapis org? |
I was thinking the following as next steps:
|
* chore: installs test_utils from common repo * fix: indentation, link errors * fix: pins sphinx<3.0.0 Refer googleapis/google-cloud-python#10327
Can this be closed now? I can see that the new test utils repo now exists (thanks!), and some of the libraries already used it. I also already opened PRs in BigQuery and PubSub to clean the There is probably a better chance that library maintainers will see this if we open cleanup tickets in the library repos directly? |
* chore: installs test_utils from common repo * fix: indentation, link errors * fix: pins sphinx<3.0.0 Refer #10327
Libraries can no longer install
test_utils
from a shared library once they are in a split repo.Create a new repository for
test_utils
, and modify noxfiles to installtest_utils
from the git repo directly.The text was updated successfully, but these errors were encountered: