Return 'NotImplemented', rather than raising 'NotImplementedError', f…

…rom eq. See: https://docs.python.org/2/reference/datamodel.html#the-standard-type-hierarchy.
googleapis · Feb 12, 2015 · f5e4b40 · f5e4b40
1 parent 5badbc4
commit f5e4b40
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/gcloud/datastore/entity.py b/gcloud/datastore/entity.py
@@ -87,7 +87,7 @@ def __eq__(self, other):
         :returns: True if the entities compare equal, else False.
         """
         if not isinstance(other, Entity):
-            raise NotImplementedError
+            return NotImplemented
 
         return (self.key == other.key and
                 dict(self) == dict(other))

diff --git a/gcloud/datastore/key.py b/gcloud/datastore/key.py
@@ -87,7 +87,7 @@ def __eq__(self, other):
         :returns: True if the keys compare equal, else False.
         """
         if not isinstance(other, Key):
-            raise NotImplementedError
+            return NotImplemented
 
         if self.is_partial or other.is_partial:
             return False