Skip to content

Commit

Permalink
Merge pull request #863 from dhermes/fix-791
Browse files Browse the repository at this point in the history
Using storage.googleapis.com in public URL.
  • Loading branch information
dhermes committed May 8, 2015
2 parents a9bc7fe + 56bc428 commit a59dc9d
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 3 deletions.
2 changes: 1 addition & 1 deletion gcloud/storage/blob.py
Original file line number Diff line number Diff line change
Expand Up @@ -162,7 +162,7 @@ def public_url(self):
:returns: The public URL for this blob.
"""
return '{storage_base_url}/{bucket_name}/{quoted_name}'.format(
storage_base_url='http://commondatastorage.googleapis.com',
storage_base_url='https://storage.googleapis.com',
bucket_name=self.bucket.name,
quoted_name=quote(self.name, safe=''))

Expand Down
4 changes: 2 additions & 2 deletions gcloud/storage/test_blob.py
Original file line number Diff line number Diff line change
Expand Up @@ -143,7 +143,7 @@ def test_public_url(self):
bucket = _Bucket(connection)
blob = self._makeOne(BLOB_NAME, bucket=bucket)
self.assertEqual(blob.public_url,
'http://commondatastorage.googleapis.com/name/%s' %
'https://storage.googleapis.com/name/%s' %
BLOB_NAME)

def test_public_url_w_slash_in_name(self):
Expand All @@ -153,7 +153,7 @@ def test_public_url_w_slash_in_name(self):
blob = self._makeOne(BLOB_NAME, bucket=bucket)
self.assertEqual(
blob.public_url,
'http://commondatastorage.googleapis.com/name/parent%2Fchild')
'https://storage.googleapis.com/name/parent%2Fchild')

def _basic_generate_signed_url_helper(self, credentials=None):
from gcloud._testing import _Monkey
Expand Down

0 comments on commit a59dc9d

Please sign in to comment.