Skip to content

Commit

Permalink
ci: Treat sphinx warnings as errors (#196)
Browse files Browse the repository at this point in the history
* ci: Treat sphinx warnings as errors

* 🦉 Updates from OwlBot

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
  • Loading branch information
parthea and gcf-owl-bot[bot] authored Aug 9, 2021
1 parent 41a6f3c commit 94e3aa0
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 5 deletions.
2 changes: 1 addition & 1 deletion packages/google-cloud-monitoring/noxfile.py
Original file line number Diff line number Diff line change
Expand Up @@ -184,7 +184,7 @@ def docs(session):
shutil.rmtree(os.path.join("docs", "_build"), ignore_errors=True)
session.run(
"sphinx-build",
# "-W", # warnings as errors
"-W", # warnings as errors
"-T", # show full traceback on exception
"-N", # no colors
"-b",
Expand Down
5 changes: 1 addition & 4 deletions packages/google-cloud-monitoring/owlbot.py
Original file line number Diff line number Diff line change
Expand Up @@ -89,13 +89,10 @@
)
s.move(templated_files, excludes=[".coveragerc"]) # microgenerator has a good .coveragerc file

# Don't treat docs (sphinx) warnings as errors.
s.replace("noxfile.py", '[\"\']-W[\"\']', '# "-W"')

# ----------------------------------------------------------------------------
# Samples templates
# ----------------------------------------------------------------------------
python.py_samples(skip_readmes=True)


s.shell.run(["nox", "-s", "blacken"], hide_output=False)
s.shell.run(["nox", "-s", "blacken"], hide_output=False)

0 comments on commit 94e3aa0

Please sign in to comment.