Skip to content

Commit

Permalink
Security Center: remove 'having' filter arguments from query methods …
Browse files Browse the repository at this point in the history 
…(via synth).
  • Loading branch information
@yoshi-automation @busunkim96
yoshi-automation authored and busunkim96 committed Mar 15, 2019
1 parent f242cc1 commit 414f026
Show file tree
Hide file tree
Showing 4 changed files with 69 additions and 195 deletions.
22 changes: 0 additions & 22 deletions securitycenter/google/cloud/securitycenter_v1/gapic/security_center_client.py
View file
Original file line number Diff line number Diff line change
Expand Up @@ -566,7 +566,6 @@ def group_assets(
filter_=None,
compare_duration=None,
read_time=None,
having=None,
page_size=None,
retry=google.api_core.gapic_v1.method.DEFAULT,
timeout=google.api_core.gapic_v1.method.DEFAULT,
Expand Down Expand Up @@ -682,9 +681,6 @@ def group_assets(
If a dict is provided, it must be of the same form as the protobuf
message :class:`~google.cloud.securitycenter_v1.types.Timestamp`
having (str): Filter that specifies what fields to further filter on *after* the query
filter has been executed. Currently only 'state\_change' is supported
and requires compare\_duration to be specified.
page_size (int): The maximum number of resources contained in the
underlying API response. If page streaming is performed per-
resource, this parameter does not affect the return value. If page
Expand Down Expand Up @@ -729,7 +725,6 @@ def group_assets(
filter=filter_,
compare_duration=compare_duration,
read_time=read_time,
having=having,
page_size=page_size,
)
iterator = google.api_core.page_iterator.GRPCIterator(
Expand All @@ -754,7 +749,6 @@ def group_findings(
filter_=None,
read_time=None,
compare_duration=None,
having=None,
page_size=None,
retry=google.api_core.gapic_v1.method.DEFAULT,
timeout=google.api_core.gapic_v1.method.DEFAULT,
Expand Down Expand Up @@ -869,10 +863,6 @@ def group_findings(
If a dict is provided, it must be of the same form as the protobuf
message :class:`~google.cloud.securitycenter_v1.types.Duration`
having (str): Filter that specifies what fields to further filter on *after* the query
filter has been executed. Currently only 'finding.state' and
'state\_change' are supported and requires compare\_duration to be
specified.
page_size (int): The maximum number of resources contained in the
underlying API response. If page streaming is performed per-
resource, this parameter does not affect the return value. If page
Expand Down Expand Up @@ -917,7 +907,6 @@ def group_findings(
filter=filter_,
read_time=read_time,
compare_duration=compare_duration,
having=having,
page_size=page_size,
)
iterator = google.api_core.page_iterator.GRPCIterator(
Expand All @@ -942,7 +931,6 @@ def list_assets(
order_by=None,
read_time=None,
compare_duration=None,
having=None,
field_mask=None,
page_size=None,
retry=google.api_core.gapic_v1.method.DEFAULT,
Expand Down Expand Up @@ -1047,9 +1035,6 @@ def list_assets(
If a dict is provided, it must be of the same form as the protobuf
message :class:`~google.cloud.securitycenter_v1.types.Duration`
having (str): Filter that specifies what fields to further filter on *after* the query
filter has been executed. Currently only 'state\_change' is supported
and requires compare\_duration to be specified.
field_mask (Union[dict, ~google.cloud.securitycenter_v1.types.FieldMask]): Optional.
A field mask to specify the ListAssetsResult fields to be listed in the
Expand Down Expand Up @@ -1102,7 +1087,6 @@ def list_assets(
order_by=order_by,
read_time=read_time,
compare_duration=compare_duration,
having=having,
field_mask=field_mask,
page_size=page_size,
)
Expand All @@ -1128,7 +1112,6 @@ def list_findings(
order_by=None,
read_time=None,
compare_duration=None,
having=None,
field_mask=None,
page_size=None,
retry=google.api_core.gapic_v1.method.DEFAULT,
Expand Down Expand Up @@ -1234,10 +1217,6 @@ def list_findings(
If a dict is provided, it must be of the same form as the protobuf
message :class:`~google.cloud.securitycenter_v1.types.Duration`
having (str): Filter that specifies what fields to further filter on *after* the query
filter has been executed. Currently only 'finding.state' and
'state\_change' are supported and requires compare\_duration to be
specified.
field_mask (Union[dict, ~google.cloud.securitycenter_v1.types.FieldMask]): Optional.
A field mask to specify the Finding fields to be listed in the response.
Expand Down Expand Up @@ -1289,7 +1268,6 @@ def list_findings(
order_by=order_by,
read_time=read_time,
compare_duration=compare_duration,
having=having,
field_mask=field_mask,
page_size=page_size,
)
Expand Down
28 changes: 8 additions & 20 deletions securitycenter/google/cloud/securitycenter_v1/proto/securitycenter_service.proto
View file
Original file line number Diff line number Diff line change
Expand Up @@ -331,11 +331,6 @@ message GroupAssetsRequest {
// NOW.
google.protobuf.Timestamp read_time = 5;

// Filter that specifies what fields to further filter on *after* the query
// filter has been executed. Currently only 'state_change' is supported and
// requires compare_duration to be specified.
string having = 6;

// The value returned by the last `GroupAssetsResponse`; indicates
// that this is a continuation of a prior `GroupAssets` call, and that the
// system should return the next page of data.
Expand All @@ -344,6 +339,8 @@ message GroupAssetsRequest {
// The maximum number of results to return in a single response. Default is
// 10, minimum is 1, maximum is 1000.
int32 page_size = 8;

reserved 6;
}

// Response message for grouping by assets.
Expand Down Expand Up @@ -446,11 +443,6 @@ message GroupFindingsRequest {
// `group_by`.
google.protobuf.Duration compare_duration = 5;

// Filter that specifies what fields to further filter on *after* the query
// filter has been executed. Currently only 'finding.state' and 'state_change'
// are supported and requires compare_duration to be specified.
string having = 6;

// The value returned by the last `GroupFindingsResponse`; indicates
// that this is a continuation of a prior `GroupFindings` call, and
// that the system should return the next page of data.
Expand All @@ -459,6 +451,8 @@ message GroupFindingsRequest {
// The maximum number of results to return in a single response. Default is
// 10, minimum is 1, maximum is 1000.
int32 page_size = 8;

reserved 6;
}

// Response message for group by findings.
Expand Down Expand Up @@ -591,11 +585,6 @@ message ListAssetsRequest {
// read_time.
google.protobuf.Duration compare_duration = 5;

// Filter that specifies what fields to further filter on *after* the query
// filter has been executed. Currently only 'state_change' is supported and
// requires compare_duration to be specified.
string having = 6;

// Optional.
//
// A field mask to specify the ListAssetsResult fields to be listed in the
Expand All @@ -611,6 +600,8 @@ message ListAssetsRequest {
// The maximum number of results to return in a single response. Default is
// 10, minimum is 1, maximum is 1000.
int32 page_size = 9;

reserved 6;
}

// Response message for listing assets.
Expand Down Expand Up @@ -735,11 +726,6 @@ message ListFindingsRequest {
// read_time.
google.protobuf.Duration compare_duration = 5;

// Filter that specifies what fields to further filter on *after* the query
// filter has been executed. Currently only 'finding.state' and 'state_change'
// are supported and requires compare_duration to be specified.
string having = 6;

// Optional.
//
// A field mask to specify the Finding fields to be listed in the response.
Expand All @@ -754,6 +740,8 @@ message ListFindingsRequest {
// The maximum number of results to return in a single response. Default is
// 10, minimum is 1, maximum is 1000.
int32 page_size = 9;

reserved 6;
}

// Response message for listing findings.
Expand Down
Loading

0 comments on commit 414f026

Please sign in to comment.