Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(tests): run emulator tests if the tests are modified, fix spanner emulator #5643

Merged
merged 6 commits into from
Nov 22, 2022

Conversation

bshaffer
Copy link
Contributor

No description provided.

@bshaffer bshaffer changed the title chore(tests): fix spanner emulator and emulator test paths chore(tests): run emulator tests if the tests are modified, fix spanner emulator Nov 22, 2022
name: Run Spanner System Tests With Emulator
jobs:
test:
runs-on: ubuntu-latest
runs-on: ubuntu-20.04
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bshaffer bshaffer marked this pull request as ready for review November 22, 2022 16:11
@bshaffer bshaffer requested review from a team as code owners November 22, 2022 16:11
Copy link
Contributor

@ajupazhamayil ajupazhamayil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for this change :-)

Copy link
Contributor

@vishwarajanand vishwarajanand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for addressing this

@bshaffer bshaffer merged commit 1d69935 into main Nov 22, 2022
@bshaffer bshaffer deleted the fix-spanner-emulator-and-test-paths branch November 22, 2022 20:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants