Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Example for GCE in authorization documentation seems wrong #712

Closed
jacobsa opened this issue Jul 9, 2015 · 3 comments
Closed

Example for GCE in authorization documentation seems wrong #712

jacobsa opened this issue Jul 9, 2015 · 3 comments
Assignees

Comments

@jacobsa
Copy link

jacobsa commented Jul 9, 2015

In the section called "On Google Compute Engine", this page says that authorization is handled for me with no configuration. But the example directly below shows using an explicit JSON key file:

var config = {
  projectId: 'grape-spaceship-123',
  keyFilename: '/path/to/keyfile.json'
};

var gcloud = require('gcloud')(config);

In fact, this is identical to the example used in the "Elsewhere" section.

@stephenplusplus
Copy link
Contributor

Great catch, thank you! PR is very welcome if you're up for it :)

@jacobsa
Copy link
Author

jacobsa commented Jul 9, 2015

Okay, will do.

@jacobsa
Copy link
Author

jacobsa commented Jul 9, 2015

@stephenplusplus: Actually, this already looks correct here (modulo incorrect Markdown syntax, which I've sent a pull request for). How is that page generated?

sofisl pushed a commit that referenced this issue Nov 17, 2022
- [ ] Regenerate this pull request now.

Source-Link: googleapis/googleapis@fd16b6a

Source-Link: googleapis/googleapis-gen@d935b98
Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiZDkzNWI5ODQ3YTFiNzA4YWI0ZTY5NjMyMGJhNjBjZTAzNDFjNWQ3YSJ9

fix(compute): replace missing REQUIRED for parent_id (#711)
Source-Link: googleapis/googleapis@4bb6fd6

Source-Link: googleapis/googleapis-gen@c7d0653
Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiYzdkMDY1MzNiZTZlMjQ3MGUzNmI5ZjM1MWFlNGZmNDc5YTQ3ZGM1MyJ9
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants