Skip to content

Commit

Permalink
fix(compute): revert proto3_optional, required removal on parent_id (#…
Browse files Browse the repository at this point in the history
…714) (#717)

* fix(compute): revert proto3_optional, required removal on parent_id (#714)

Source-Link: googleapis/googleapis@6b3fdce

Source-Link: googleapis/googleapis-gen@832dbe9
Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiODMyZGJlOTk4ODc4ZDg2MTlkNmI0MGZlNTdjNmQyY2M2ZTdkYzkwYyJ9

* 🦉 Updates from OwlBot post-processor

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
  • Loading branch information
gcf-owl-bot[bot] and gcf-owl-bot[bot] authored Apr 26, 2022
1 parent b570c09 commit 0e00c4b
Show file tree
Hide file tree
Showing 6 changed files with 17 additions and 35 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -16439,7 +16439,10 @@ message MoveFirewallPolicyRequest {
string firewall_policy = 498173265 [(google.api.field_behavior) = REQUIRED];

// The new parent of the firewall policy.
optional string parent_id = 459714768 [(google.cloud.operation_request_field) = "parent_id"];
string parent_id = 459714768 [
(google.api.field_behavior) = REQUIRED,
(google.cloud.operation_request_field) = "parent_id"
];

// An optional request ID to identify requests. Specify a unique request ID so that if you must retry your request, the server will know to ignore the request if it has already been completed. For example, consider a situation where you make an initial request and the request times out. If you make the request again with the same request ID, the server can check if original operation with the same request ID was received, and if so, will ignore the second request. This prevents clients from accidentally creating duplicate commitments. The request ID must be a valid UUID with the exception that zero UUID is not supported ( 00000000-0000-0000-0000-000000000000).
optional string request_id = 37109963;
Expand Down
5 changes: 1 addition & 4 deletions packages/google-cloud-compute/protos/protos.d.ts

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

28 changes: 7 additions & 21 deletions packages/google-cloud-compute/protos/protos.js

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

9 changes: 2 additions & 7 deletions packages/google-cloud-compute/protos/protos.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@

'use strict';

function main(firewallPolicy) {
function main(firewallPolicy, parentId) {
// [START compute_v1_generated_FirewallPolicies_Move_async]
/**
* TODO(developer): Uncomment these variables before running the sample.
Expand Down Expand Up @@ -48,6 +48,7 @@ function main(firewallPolicy) {
// Construct request
const request = {
firewallPolicy,
parentId,
};

// Run request
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -3662,7 +3662,7 @@
"segments": [
{
"start": 25,
"end": 58,
"end": 59,
"type": "FULL"
}
],
Expand Down

0 comments on commit 0e00c4b

Please sign in to comment.