Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: [metastore] added ScalingConfig (v1) #9350

Merged
merged 5 commits into from
Apr 26, 2023
Merged

feat: [metastore] added ScalingConfig (v1) #9350

merged 5 commits into from
Apr 26, 2023

Conversation

gcf-owl-bot[bot]
Copy link
Contributor

@gcf-owl-bot gcf-owl-bot bot commented Apr 14, 2023 •
edited
Loading

  • Regenerate this pull request now.

feat: added Auxiliary Versions Config (v1)
feat: added Dataplex and BQ metastore types for federation (v1alpa, v1beta)

PiperOrigin-RevId: 524313740

Source-Link: googleapis/googleapis@63d1a0e

Source-Link: https://github.com/googleapis/googleapis-gen/commit/400e991cfd3730a363adfb387444e5a6c624a411
Copy-Tag: eyJwIjoiamF2YS1kYXRhcHJvYy1tZXRhc3RvcmUvLk93bEJvdC55YW1sIiwiaCI6IjQwMGU5OTFjZmQzNzMwYTM2M2FkZmIzODc0NDRlNWE2YzYyNGE0MTEifQ==

@trusted-contributions-gcf trusted-contributions-gcf bot added kokoro:force-run Add this label to force Kokoro to re-run the tests. owlbot:run Add this label to trigger the Owlbot post processor. labels Apr 14, 2023
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Apr 14, 2023
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Apr 14, 2023
@trusted-contributions-gcf trusted-contributions-gcf bot added kokoro:force-run Add this label to force Kokoro to re-run the tests. owlbot:run Add this label to trigger the Owlbot post processor. labels Apr 14, 2023
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Apr 14, 2023
@snippet-bot
Copy link

snippet-bot bot commented Apr 14, 2023 •
edited
Loading

Here is the summary of changes.

You are about to add 66 region tags.

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:

  • Refresh this comment

@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Apr 14, 2023
@emmileaf
Copy link
Contributor

emmileaf commented Apr 25, 2023 •
edited
Loading

Will need to add dependencies manually to pom. Regenerating this PR first to include changes from #9357.

Log from failing presubmits:

Error: 0:227 [ERROR] Failed to execute goal org.apache.maven.plugins:maven-compiler-plugin:3.10.1:compile (default-compile) on project google-cloud-dataproc-metastore: Compilation failure: Compilation failure: 
Error: 0:227 [ERROR] /home/runner/work/google-cloud-java/google-cloud-java/java-dataproc-metastore/google-cloud-dataproc-metastore/src/main/java/com/google/cloud/metastore/v1/DataprocMetastoreFederationClient.java:[38,25] package com.google.iam.v1 does not exist
Error: 0:228 [ERROR] /home/runner/work/google-cloud-java/google-cloud-java/java-dataproc-metastore/google-cloud-dataproc-metastore/src/main/java/com/google/cloud/metastore/v1/DataprocMetastoreFederationClient.java:[39,25] package com.google.iam.v1 does not exist
Error: 0:228 [ERROR] /home/runner/work/google-cloud-java/google-cloud-java/java-dataproc-metastore/google-cloud-dataproc-metastore/src/main/java/com/google/cloud/metastore/v1/DataprocMetastoreFederationClient.java:[40,25] package com.google.iam.v1 does not exist
Error: 0:228 [ERROR] /home/runner/work/google-cloud-java/google-cloud-java/java-dataproc-metastore/google-cloud-dataproc-metastore/src/main/java/com/google/cloud/metastore/v1/DataprocMetastoreFederationClient.java:[41,25] package com.google.iam.v1 does not exist
Error: 0:228 [ERROR] /home/runner/work/google-cloud-java/google-cloud-java/java-dataproc-metastore/google-cloud-dataproc-metastore/src/main/java/com/google/cloud/metastore/v1/DataprocMetastoreFederationClient.java:[42,25] package com.google.iam.v1 does not exist
Error: 0:228 [ERROR] /home/runner/work/google-cloud-java/google-cloud-java/java-dataproc-metastore/google-cloud-dataproc-metastore/src/main/java/com/google/cloud/metastore/v1/stub/HttpJsonDataprocMetastoreFederationStub.java:[51,25] package com.google.iam.v1 does not exist
Error: 0:228 [ERROR] /home/runner/work/google-cloud-java/google-cloud-java/java-dataproc-metastore/google-cloud-dataproc-metastore/src/main/java/com/google/cloud/metastore/v1/stub/HttpJsonDataprocMetastoreFederationStub.java:[52,25] package com.google.iam.v1 does not exist
...

Additional errors from mvn -f java-dataproc-metastore test-compile:

[ERROR] /Users/emmwang/Working/google-cloud-java/java-dataproc-metastore/google-cloud-dataproc-metastore/src/test/java/com/google/cloud/metastore/v1/MockIAMPolicyImpl.java:[21,39] package com.google.iam.v1.IAMPolicyGrpc does not exist
[ERROR] /Users/emmwang/Working/google-cloud-java/java-dataproc-metastore/google-cloud-dataproc-metastore/src/test/java/com/google/cloud/metastore/v1/MockIAMPolicyImpl.java:[36,40] cannot find symbol
[ERROR]   symbol: class IAMPolicyImplBase

[ERROR] /Users/emmwang/Working/google-cloud-java/java-dataproc-metastore/google-cloud-dataproc-metastore/src/test/java/com/google/cloud/metastore/v1/MockLocationsImpl.java:[24,47] package com.google.cloud.location.LocationsGrpc does not exist
[ERROR] /Users/emmwang/Working/google-cloud-java/java-dataproc-metastore/google-cloud-dataproc-metastore/src/test/java/com/google/cloud/metastore/v1/MockLocationsImpl.java:[35,40] cannot find symbol
[ERROR]   symbol: class LocationsImplBase

@gcf-owl-bot
Copy link
Contributor Author

gcf-owl-bot bot commented Apr 25, 2023

Owl bot is regenerating pull request 9350...
Build name: MzgxMDE3MzAtOTBhNy00NjU0LThkZjEtNmE5Y2FkZjJjYzY0

@gcf-owl-bot
feat: added ScalingConfig (v1)
71ec9df 
feat: added Auxiliary Versions Config (v1)
feat: added Dataplex and BQ metastore types for federation (v1alpa, v1beta)

PiperOrigin-RevId: 524313740

Source-Link: googleapis/googleapis@63d1a0e

Source-Link: https://github.com/googleapis/googleapis-gen/commit/400e991cfd3730a363adfb387444e5a6c624a411
Copy-Tag: eyJwIjoiamF2YS1kYXRhcHJvYy1tZXRhc3RvcmUvLk93bEJvdC55YW1sIiwiaCI6IjQwMGU5OTFjZmQzNzMwYTM2M2FkZmIzODc0NDRlNWE2YzYyNGE0MTEifQ==
@gcf-owl-bot gcf-owl-bot bot force-pushed the owl-bot-copy-java-dataproc-metastore branch from c8c7f08 to 71ec9df Compare April 25, 2023 19:51
@trusted-contributions-gcf trusted-contributions-gcf bot added kokoro:force-run Add this label to force Kokoro to re-run the tests. owlbot:run Add this label to trigger the Owlbot post processor. labels Apr 25, 2023
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Apr 25, 2023
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Apr 25, 2023
@trusted-contributions-gcf trusted-contributions-gcf bot added kokoro:force-run Add this label to force Kokoro to re-run the tests. owlbot:run Add this label to trigger the Owlbot post processor. labels Apr 25, 2023
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Apr 25, 2023
@yoshi-kokoro yoshi-kokoro removed kokoro:force-run Add this label to force Kokoro to re-run the tests. labels Apr 25, 2023
@trusted-contributions-gcf trusted-contributions-gcf bot added kokoro:force-run Add this label to force Kokoro to re-run the tests. owlbot:run Add this label to trigger the Owlbot post processor. labels Apr 25, 2023
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Apr 25, 2023
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Apr 25, 2023
@trusted-contributions-gcf trusted-contributions-gcf bot added kokoro:force-run Add this label to force Kokoro to re-run the tests. owlbot:run Add this label to trigger the Owlbot post processor. labels Apr 25, 2023
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Apr 25, 2023
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Apr 25, 2023
@emmileaf
Copy link
Contributor

Missing dependencies were added to google-cloud-dataproc-metastore/pom.xml in 2dddb2f to resolve compile and test-compile failures. @meltsufin could you help with a review of this manual change? Thanks!

@emmileaf emmileaf requested review from emmileaf and meltsufin April 25, 2023 21:39
@emmileaf emmileaf merged commit 8174107 into main Apr 26, 2023
@emmileaf emmileaf deleted the owl-bot-copy-java-dataproc-metastore branch April 26, 2023 17:02
@release-please release-please bot mentioned this pull request Apr 26, 2023
Merged
@emmileaf emmileaf mentioned this pull request May 3, 2023
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@meltsufin meltsufin meltsufin approved these changes

@emmileaf emmileaf Awaiting requested review from emmileaf

Assignees
No one assigned
Labels
owl-bot-copy
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@emmileaf @meltsufin @yoshi-kokoro