Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rebase #734

Closed
Closed
Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
128 commits
Select commit Hold shift + click to select a range
b0c0bb7
Make bigquery functional classes extend info classes
mziccard Feb 2, 2016
3d1c1c8
Make functional objects subclasses of metadata objects.
Feb 1, 2016
94533b2
Minor refactoring bigquery functional objects
mziccard Feb 3, 2016
5829d81
Add functional classes to SerializationTest
mziccard Feb 3, 2016
aa0e377
minor fixes
Feb 3, 2016
6870eb7
Add toBuilder tests for Bucket and Blob, remove static get and builde…
Feb 4, 2016
75dbbf8
Add builder test to increase coverage
Feb 4, 2016
b6ad451
Refactor bigquery function objects builders
mziccard Feb 4, 2016
fbcbfb4
Add missing override annotation and serialVersionUID
mziccard Feb 4, 2016
4bf3796
Merge pull request #609 from mziccard/bigquery-hierachies
aozarov Feb 4, 2016
ae7e62e
try latest version of coveralls
Feb 4, 2016
7761a9e
Make Table methods public
mziccard Feb 5, 2016
3ce2cc6
Fix the 'Definition of groupId is redundant' mvn warning
mziccard Feb 5, 2016
f7990c0
Merge pull request #622 from mziccard/fix-groupid-warning
aozarov Feb 5, 2016
8ba9230
Merge pull request #621 from mziccard/bigquery-hierachies
aozarov Feb 5, 2016
288c993
Minor fixes
Feb 5, 2016
cdec697
Merge pull request #614 from ajkannan/storage-merge-objects
aozarov Feb 5, 2016
3f39ab2
Fix failing bigquery ITs due to missing queryPlan
mziccard Feb 5, 2016
d2dbd99
Merge pull request #625 from mziccard/master
aozarov Feb 5, 2016
ef7c74f
Site cleanup
Feb 6, 2016
2bb9cb0
Merge pull request #627 from ajkannan/cleanup-site
aozarov Feb 6, 2016
f06c11a
Fix NPE in bigquery XXXInfo.equals
mziccard Feb 9, 2016
3502610
Update javadoc in Table definitions (remove type naming)
mziccard Feb 9, 2016
6955bf4
Shorten line longer than 100 characters
mziccard Feb 9, 2016
307ddf3
Merge pull request #632 from mziccard/bigquery-hierachies
ajkannan Feb 9, 2016
edc9db7
Refactor examples
mziccard Feb 9, 2016
b392345
Minor refactoring of examples and READMEs
mziccard Feb 10, 2016
b8b2612
Add comment in snippet classes reminding to update docs upon change
mziccard Feb 10, 2016
384a3f1
Update example links in module's READMEs
mziccard Feb 10, 2016
6fed3ee
Rename John Do to John Doe
mziccard Feb 10, 2016
d1765c7
Fix indentation issues in javadoc code samples
Feb 10, 2016
257e764
fix lint errors
Feb 10, 2016
71ac555
Move integration tests to separate package
Feb 10, 2016
4d8d986
Avoid reading extra output during local gcd shutdown.
Feb 10, 2016
526eb5f
Fix minor documentation issues in examples
mziccard Feb 10, 2016
8c9cb2e
Rename missing John Do
mziccard Feb 10, 2016
7864a93
Merge pull request #635 from mziccard/refactor-examples
aozarov Feb 10, 2016
9d201a0
Fix codacy and spacing bugs
Feb 10, 2016
0bea6e8
Add codacy badge to READMEs
mziccard Feb 11, 2016
43aabb3
Add codacy code patterns configuration
mziccard Feb 11, 2016
bc66860
Minor fix in ITs
Feb 11, 2016
1ab48bb
Merge pull request #641 from mziccard/refactor-examples
aozarov Feb 11, 2016
deb228f
Fix double code tags
Feb 12, 2016
a68a0b6
Add set methods for lists of same type
Feb 12, 2016
8050cca
Cleaner getList return value
Feb 12, 2016
8fb9e91
Merge pull request #636 from ajkannan/minor-cleanup
aozarov Feb 12, 2016
f920986
Revert #625 and Fixes ##624
aozarov Feb 12, 2016
47dcc63
Merge pull request #644 from aozarov/master
mziccard Feb 12, 2016
4476dcf
Update dependencies when possible
mziccard Feb 12, 2016
2f77f2d
Add versioneye badge to READMEs
mziccard Feb 12, 2016
e08896c
upgrade google-api-services-datastore-protobuf to v1beta2-rev1-4.0.0 …
aozarov Feb 12, 2016
ae7c0e9
Merge pull request #645 from mziccard/dependency-versions
aozarov Feb 12, 2016
67efa01
Merge pull request #646 from aozarov/master
mziccard Feb 12, 2016
2314eee
update codacy config
aozarov Feb 13, 2016
9412d69
Merge pull request #647 from aozarov/master
mziccard Feb 15, 2016
65f4f80
Add getter for key parent
Feb 16, 2016
c2f8952
Expose consistency parameter to users of LocalGcdHelper
Feb 16, 2016
274b9ae
Add set(...) javadoc, fix key namespace issue, fix ListValue.of(...),…
Feb 17, 2016
662f57f
remove unncessary changes to ListValue
Feb 17, 2016
04ab56e
Merge pull request #648 from ajkannan/datastore-fixes
aozarov Feb 17, 2016
53290f5
fix lint issue
aozarov Feb 17, 2016
7076ab6
Merge pull request #650 from aozarov/master
ajkannan Feb 18, 2016
1f6a7b3
support paging
Feb 18, 2016
1dd2c04
Fix broken hyperlink in comment
jart Feb 18, 2016
6b322fa
minor fixes
Feb 18, 2016
df32901
Propagate page size error to user
Feb 18, 2016
b9cd1a7
catch ResourceManagerException instead of Exception
Feb 18, 2016
da544a9
Merge pull request #651 from ajkannan/resourcemanager-page
aozarov Feb 18, 2016
ff20847
Add IAM Policy classes
Feb 17, 2016
3f07b2c
move to/fromPb functions to Resource Manager
Feb 19, 2016
c96469b
variable rename to make codacy happy
Feb 19, 2016
3695ddc
Update version for release
Feb 19, 2016
df90b9f
Merge pull request #653 from ajkannan/release-0.1.4
ajkannan Feb 19, 2016
cf792d8
Updating version in README files. [ci skip]
Feb 19, 2016
60998b7
Update version to 0.1.5-SNAPSHOT
Feb 19, 2016
df52008
Merge pull request #654 from ajkannan/update-version-to-0.1.5-SNAPSHOT
ajkannan Feb 19, 2016
d72a8c6
Added "do not use production projects for tests"
mderka Feb 20, 2016
36fe287
Merge pull request #658 from GoogleCloudPlatform/mderka-doc-patch
aozarov Feb 20, 2016
e44e12a
Make BaseIamPolicy<R> in core and a subclass in Resource Manager
Feb 20, 2016
b2c2d40
Udpate dependencies: source plugin, bigquery, storage and fluido skin
mziccard Feb 24, 2016
332f990
Merge pull request #663 from mziccard/master
ajkannan Feb 24, 2016
ee78b22
Fix equals, javadoc, bindings representation, and address other comme…
Feb 22, 2016
1583e2c
Add pageToken to list fields option for GCS and resourcemanager
mziccard Feb 25, 2016
28f4a18
validateOpen throws ClosedChannelException in BaseWriteChannel and Bl…
mziccard Feb 25, 2016
119ccdf
Merge pull request #669 from mziccard/validate-open-exception
aozarov Feb 25, 2016
08295ee
Document exceptions and satisfy codacy's demands.
Feb 25, 2016
5fea7ce
Use Pattern to match list fields selector
mziccard Feb 25, 2016
a62c69d
Handle no project fields are selected on list
mziccard Feb 25, 2016
a439628
Remove non-necessary commaNeeded variable
mziccard Feb 25, 2016
7194201
Merge pull request #668 from mziccard/page-token-fields-option
aozarov Feb 25, 2016
7d87d3c
Use enum for legacy roles, add input checks
Feb 26, 2016
f4d3b95
Merge pull request #652 from ajkannan/iam
aozarov Feb 26, 2016
992a371
Remove tabs from storage and bigquery poms
mziccard Feb 29, 2016
72b4f44
Fix links to examples javadoc in READMEs
mziccard Feb 29, 2016
5ea8a8d
Merge pull request #685 from mziccard/poms-remove-tabs
ajkannan Feb 29, 2016
5c3bd9f
Use better link names for examples javadoc
mziccard Feb 29, 2016
bbe7b50
Merge pull request #686 from mziccard/master
aozarov Feb 29, 2016
21e68cc
Add a versions option to BlobListOption
aozarov Feb 29, 2016
438896b
add list versioned blobs to integration tests
aozarov Mar 1, 2016
e66c9a4
fix style and formatting issue
aozarov Mar 1, 2016
3930ff9
Merge pull request #688 from aozarov/master
mziccard Mar 1, 2016
93810ca
Replace com.google.api.client.util.Lists with Guava's Lists
mziccard Mar 1, 2016
8a3d5d8
Replace repackaged checkNotNull inclusion with Guava's
mziccard Mar 1, 2016
926831e
Merge pull request #694 from mziccard/master
aozarov Mar 1, 2016
452e274
Handle eventally consistent blob lists in storage ITs
mziccard Mar 2, 2016
a3fdbbc
Add BlobTargetOption and BlobWriteOption classes to Bucket
mziccard Mar 2, 2016
3600338
Reword javadoc in BlobTargetOption and BlobWriteOption
mziccard Mar 2, 2016
be913a6
Merge pull request #705 from mziccard/functional-bucket-options
aozarov Mar 3, 2016
622dcc9
Replace values().iterator() with iterateAll() in blob list ITs
mziccard Mar 3, 2016
50750d4
Merge pull request #704 from mziccard/fix-storage-its
mziccard Mar 3, 2016
8dd8786
Remove redundant throws from services method signatures
mziccard Mar 4, 2016
7eb957d
Merge pull request #712 from mziccard/remove-throws
aozarov Mar 4, 2016
c486452
Add NoAuthCredentials
Mar 6, 2016
8c353ec
Add javadoc
Mar 7, 2016
0c4af89
change NoAuthCredentials javadoc wording
Mar 7, 2016
d3224b3
Merge pull request #719 from ajkannan/add-no-auth
ajkannan Mar 7, 2016
cded234
Fix writes with 0 length
aozarov Mar 7, 2016
36ebabd
Fix test and issue #723
aozarov Mar 8, 2016
e70387d
Merge pull request #725 from aozarov/master
mziccard Mar 8, 2016
0f4a7a0
Release version 0.1.5
mziccard Mar 8, 2016
2611514
Merge pull request #729 from mziccard/master
mziccard Mar 8, 2016
1f1f4b0
Updating version in README files. [ci skip]
Mar 8, 2016
aa6c173
Update version to 0.1.6-SNAPSHOT
mziccard Mar 8, 2016
7c42116
Merge pull request #730 from mziccard/master
aozarov Mar 8, 2016
32060ce
Cloud Storage Java 7 nio library
jart Feb 3, 2016
c74b6fb
Migrated GCS NIO from App Engine to gcloud-storage
jean-philippe-martin Mar 2, 2016
2248848
Run google-java-format on GCS NIO
jart Mar 3, 2016
617a84e
Correct more style issues and remove warnings
jart Mar 4, 2016
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fix NPE in bigquery XXXInfo.equals
  • Loading branch information
mziccard committed Feb 9, 2016
commit f06c11acea61862a629e1170032af486cd31495a
Original file line number Diff line number Diff line change
Expand Up @@ -396,7 +396,8 @@ public int hashCode() {

@Override
public boolean equals(Object obj) {
return obj.getClass().equals(DatasetInfo.class)
return obj != null
&& obj.getClass().equals(DatasetInfo.class)
&& Objects.equals(toPb(), ((DatasetInfo) obj).toPb());
}

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -319,7 +319,9 @@ public int hashCode() {

@Override
public boolean equals(Object obj) {
return obj.getClass().equals(JobInfo.class) && Objects.equals(toPb(), ((JobInfo) obj).toPb());
return obj != null
&& obj.getClass().equals(JobInfo.class)
&& Objects.equals(toPb(), ((JobInfo) obj).toPb());
}

JobInfo setProjectId(String projectId) {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -339,7 +339,8 @@ public int hashCode() {

@Override
public boolean equals(Object obj) {
return obj.getClass().equals(TableInfo.class)
return obj != null
&& obj.getClass().equals(TableInfo.class)
&& Objects.equals(toPb(), ((TableInfo) obj).toPb());
}

Expand Down