Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create BaseServiceException in gcloud-java-core #324

Merged
merged 2 commits into from
Nov 5, 2015
Merged

Create BaseServiceException in gcloud-java-core #324

merged 2 commits into from
Nov 5, 2015

Conversation

ajkannan
Copy link

@ajkannan ajkannan commented Nov 5, 2015

(as suggested in #315's discussion)

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Nov 5, 2015
@ajkannan
Copy link
Author

ajkannan commented Nov 5, 2015

I was contemplating changing the Code/ErrorInfo enum to an enum of DatastoreExceptions (in DatastoreException.java), since the code/httpStatus and retryable fields are repeated in the class and the Code/ErrorInfo. Would that be preferable?

aozarov
aozarov reviewed Nov 5, 2015
View reviewed changes
gcloud-java-core/src/main/java/com/google/gcloud/BaseServiceException.java
package com.google.gcloud;

/**
* Base service exception.

This comment was marked as spam.

Sign in to view

@ajkannan
Copy link
Author

ajkannan commented Nov 5, 2015

@aozarov comments incorporated, made enum accessors package private, and renamed enum.

aozarov added a commit that referenced this pull request Nov 5, 2015
@aozarov
Merge pull request #324 from ajkannan/base-exception
561af74 
Create BaseServiceException in gcloud-java-core
@aozarov aozarov merged commit 561af74 into googleapis:master Nov 5, 2015
@aozarov aozarov mentioned this pull request Nov 5, 2015
Closed
@ajkannan ajkannan deleted the base-exception branch November 10, 2015 21:34
github-actions bot pushed a commit to suztomo/google-cloud-java that referenced this pull request Jun 29, 2022
@release-please
chore: release 0.118.6-SNAPSHOT (googleapis#324)
e5288c8 
🤖 I have created a release \*beep\* \*boop\* 
---
### Updating meta-information for bleeding-edge SNAPSHOT release.
---


This PR was generated with [Release Please](https://github.com/googleapis/release-please).
github-actions bot pushed a commit that referenced this pull request Jul 1, 2022
@suztomo
ci: removing linkage-monitor from the required checks (#324)
2b72589 
Linkage Monitor is no longer needed, because the Libraries BOM synchronizes with Google Cloud BOM and the shared dependencies BOM GoogleCloudPlatform/cloud-opensource-java#2137
github-actions bot pushed a commit that referenced this pull request Jul 14, 2022
@mpeddada1 @gcf-owl-bot @alicejli
chore: mark native image checks as required (#324)
380dfae 
* chore: add native image checks as required

* 🦉 Updates from OwlBot post-processor

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
Co-authored-by: Alice <65933803+alicejli@users.noreply.github.com>
github-actions bot pushed a commit that referenced this pull request Jul 14, 2022
@gcf-owl-bot
fix: enable longpaths support for windows test (#1485) (#324)
3fe7c33 
Source-Link: googleapis/synthtool@7336562
Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-java:latest@sha256:d4b80feffe1579818cdc39466152e9de95789a193408506cd4a1ffbe8804dc00
github-actions bot pushed a commit that referenced this pull request Jul 14, 2022
@release-please
chore(main): release 3.7.1 (#325)
f076b7b 
🤖 I have created a release *beep* *boop*
---


## [3.7.1](googleapis/java-channel@v3.7.0...v3.7.1) (2022-07-13)


### Bug Fixes

* enable longpaths support for windows test ([#1485](https://github.com/googleapis/java-channel/issues/1485)) ([#324](googleapis/java-channel#324)) ([3fe7c33](googleapis/java-channel@3fe7c33))

---
This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
github-actions bot pushed a commit that referenced this pull request Aug 9, 2022
@release-please
chore(main): release 2.3.8-SNAPSHOT (#324)
a61eeae 
🤖 I have created a release *beep* *boop*
---


### Updating meta-information for bleeding-edge SNAPSHOT release.

---
This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
github-actions bot pushed a commit to yoshi-code-bot/google-cloud-java that referenced this pull request Oct 6, 2022
@renovate-bot
chore(deps): update dependency com.google.cloud:google-cloud-networkc…
c7b9073 
…onnectivity to v1.2.8 (googleapis#324)

[![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Change | Age | Adoption | Passing | Confidence |
|---|---|---|---|---|---|
| [com.google.cloud:google-cloud-networkconnectivity](https://togithub.com/googleapis/java-networkconnectivity) ([source](https://togithub.com/googleapis/java-)) | `1.2.7` -> `1.2.9` | [![age](https://badges.renovateapi.com/packages/maven/com.google.cloud:google-cloud-networkconnectivity/1.2.9/age-slim)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://badges.renovateapi.com/packages/maven/com.google.cloud:google-cloud-networkconnectivity/1.2.9/adoption-slim)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://badges.renovateapi.com/packages/maven/com.google.cloud:google-cloud-networkconnectivity/1.2.9/compatibility-slim/1.2.7)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://badges.renovateapi.com/packages/maven/com.google.cloud:google-cloud-networkconnectivity/1.2.9/confidence-slim/1.2.7)](https://docs.renovatebot.com/merge-confidence/) |

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied.

♻ **Rebasing**: Renovate will not automatically rebase this PR, because other commits have been found.

🔕 **Ignore**: Close this PR and you won't be reminded about these updates again.

---

 - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, click this checkbox. ⚠ **Warning**: custom changes will be lost.

---

This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://app.renovatebot.com/dashboard#github/googleapis/java-networkconnectivity).
<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzMi4yMTcuMCIsInVwZGF0ZWRJblZlciI6IjMyLjIxNy4wIn0=-->
github-actions bot pushed a commit to yoshi-code-bot/google-cloud-java that referenced this pull request Nov 8, 2022
@gcf-owl-bot @chingor13
chore(java): add a note in README for migrated split repos (googleapi…
d9abbe6 
…s#1687) (googleapis#324)

* chore(java): add a note in README for migrated split repos

Disable renovate bot and flaky bot for split repositories
that have moved to the Java monorepo.
The Java monorepo will pass the "monorepo=True" parameter
to java.common_templates method in its owlbot.py files so that
the migration note will not appear in the README in the monorepo.

Co-authored-by: Jeff Ching <chingor@google.com>
Source-Link: https://togithub.com/googleapis/synthtool/commit/d4b291604f148cde065838c498bc8aa79b8dc10e
Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-java:latest@sha256:edae91ccdd2dded2f572ec341a768ad180305a3e8fbfd93064b28e237d35920a
suztomo pushed a commit that referenced this pull request Feb 1, 2023
@renovate-bot
deps: update dependency com.google.protobuf:protobuf-java to v3.20.0 (#…
852fd1a 
…324)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
api: core cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ajkannan @aozarov @googlebot