Create packages for resource manager and outline spi layer. #314

ajkannan · 2015-11-02T17:31:37Z

Note: I named the module "gcloud-java-resource-manager" (with a dash between "resource" and "manager"). For the package name I didn't separate the words (it's com.google.gcloud.resourcemanager). Let me know if it would be better to standardize and name the module "gcloud-java-resourcemanager."

...source-manager/src/main/java/com/google/gcloud/resourcemanager/ResourceManagerException.java

+    if (ex instanceof RetryHelper.RetryInterruptedException) {
+      RetryHelper.RetryInterruptedException.propagate();
+    }
+    throw new ResourceManagerException(UNKNOWN_CODE, ex.getMessage(), false);


gcloud-java-resourcemanager/src/main/java/com/google/gcloud/spi/ResourceManagerRpc.java

+
+  Tuple<String, Iterable<Project>> list() throws ResourceManagerException;
+
+  Tuple<String, Iterable<Project>> list(String filter) throws ResourceManagerException;


aozarov · 2015-11-03T01:17:22Z

For the record, we agreed to keep naming style and directory style consistent (gcloud-java-resourcemanage).

…to pom files spi api fixes

ajkannan · 2015-11-03T02:01:16Z

@aozarov comments incorporated

ajkannan · 2015-11-03T16:38:21Z

@aozarov updated to include comments. I also changed "hasPermissions" to take varargs instead of a list. I think varargs are probably nicer for anybody using the low-level api, because they may only test one or two permissions at a time.

Edit: will put this in the api layer, not the spi layer

gcloud-java-resourcemanager/src/main/java/com/google/gcloud/spi/ResourceManagerRpc.java

+    LIST,
+    UPDATE,
+    GET_IAM_POLICY,
+    SET_IAM_POLICY;


ajkannan · 2015-11-03T18:22:15Z

@aozarov comments included, and I added DeleteResult and UndeleteResult as return types for delete and undelete.

ajkannan · 2015-11-03T21:45:03Z

We could probably add a return type for SetIamPolicy as well. It can fail to set the policy if the user chooses to supply an etag and that etag doesn't match the server policy's etag.

gcloud-java-resourcemanager/src/main/java/com/google/gcloud/spi/ResourceManagerRpc.java

+
+  public enum SetIamPolicyResult {
+    SUCCESS,
+    ETAG_NOT_MATCH


aozarov · 2015-11-04T00:26:01Z

Hey @ajkannan. Looks good, few nits and a couple of questions.

gcloud-java-resourcemanager/src/main/java/com/google/gcloud/spi/ResourceManagerRpc.java

+
+  Project update(Project project) throws ResourceManagerException;
+
+  Policy getIamPolicy(String projectId) throws ResourceManagerException;


ajkannan · 2015-11-04T21:02:59Z

@aozarov comments addressed, removed extraneous enums, and changed "update"/"set" terminology to "replace"

Create packages for resource manager and outline spi layer.

…oogleapis#314)

…to v3.6.1 (googleapis#314) [![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [com.google.cloud:google-cloud-channel](https://togithub.com/googleapis/java-) | `3.6.0` -> `3.6.1` | [![age](https://badges.renovateapi.com/packages/maven/com.google.cloud:google-cloud-channel/3.6.1/age-slim)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://badges.renovateapi.com/packages/maven/com.google.cloud:google-cloud-channel/3.6.1/adoption-slim)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://badges.renovateapi.com/packages/maven/com.google.cloud:google-cloud-channel/3.6.1/compatibility-slim/3.6.0)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://badges.renovateapi.com/packages/maven/com.google.cloud:google-cloud-channel/3.6.1/confidence-slim/3.6.0)](https://docs.renovatebot.com/merge-confidence/) | --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Renovate will not automatically rebase this PR, because other commits have been found. 🔕 **Ignore**: Close this PR and you won't be reminded about these updates again. --- - [ ] If you want to rebase/retry this PR, click this checkbox. ⚠ **Warning**: custom changes will be lost. --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://app.renovatebot.com/dashboard#github/googleapis/java-channel).

…onfig to v1.5.1 (#314) [![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [com.google.cloud:google-cloud-shared-config](https://togithub.com/googleapis/java-shared-config) | `1.5.0` -> `1.5.1` | [![age](https://badges.renovateapi.com/packages/maven/com.google.cloud:google-cloud-shared-config/1.5.1/age-slim)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://badges.renovateapi.com/packages/maven/com.google.cloud:google-cloud-shared-config/1.5.1/adoption-slim)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://badges.renovateapi.com/packages/maven/com.google.cloud:google-cloud-shared-config/1.5.1/compatibility-slim/1.5.0)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://badges.renovateapi.com/packages/maven/com.google.cloud:google-cloud-shared-config/1.5.1/confidence-slim/1.5.0)](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>googleapis/java-shared-config</summary> ### [`v1.5.1`](https://togithub.com/googleapis/java-shared-config/blob/HEAD/CHANGELOG.md#151-httpsgithubcomgoogleapisjava-shared-configcomparev150v151-2022-06-30) [Compare Source](https://togithub.com/googleapis/java-shared-config/compare/v1.5.0...v1.5.1) ##### Dependencies - update dependency org.graalvm.buildtools:junit-platform-native to v0.9.12 ([#482](https://togithub.com/googleapis/java-shared-config/issues/482)) ([fbfc6dc](https://togithub.com/googleapis/java-shared-config/commit/fbfc6dc1329faaead3a3114c8599d9267722e7f0)) - update dependency org.graalvm.buildtools:native-maven-plugin to v0.9.12 ([#483](https://togithub.com/googleapis/java-shared-config/issues/483)) ([336cb78](https://togithub.com/googleapis/java-shared-config/commit/336cb7827b36583228c9e2b85871ae72f4c55975)) </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this PR, click this checkbox. --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://app.renovatebot.com/dashboard#github/googleapis/java-contact-center-insights).

🤖 I have created a release *beep* *boop* --- ### Updating meta-information for bleeding-edge SNAPSHOT release. --- This PR was generated with [Release Please](https://togithub.com/googleapis/release-please). See [documentation](https://togithub.com/googleapis/release-please#release-please).

…-metastore to v2.4.4 (googleapis#314) [![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [com.google.cloud:google-cloud-dataproc-metastore](https://togithub.com/googleapis/java-dataproc-metastore) | `2.4.3` -> `2.4.4` | [![age](https://badges.renovateapi.com/packages/maven/com.google.cloud:google-cloud-dataproc-metastore/2.4.4/age-slim)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://badges.renovateapi.com/packages/maven/com.google.cloud:google-cloud-dataproc-metastore/2.4.4/adoption-slim)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://badges.renovateapi.com/packages/maven/com.google.cloud:google-cloud-dataproc-metastore/2.4.4/compatibility-slim/2.4.3)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://badges.renovateapi.com/packages/maven/com.google.cloud:google-cloud-dataproc-metastore/2.4.4/confidence-slim/2.4.3)](https://docs.renovatebot.com/merge-confidence/) | --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Renovate will not automatically rebase this PR, because other commits have been found. 🔕 **Ignore**: Close this PR and you won't be reminded about these updates again. --- - [ ] If you want to rebase/retry this PR, click this checkbox. ⚠ **Warning**: custom changes will be lost. --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://app.renovatebot.com/dashboard#github/googleapis/java-dataproc-metastore).

* chore: [java] generation with shared deps 3.0.4 * fix for tests Source-Link: https://togithub.com/googleapis/synthtool/commit/c3ad3cc9d876a3dd897cc511cf5ef921784851ae Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-java:latest@sha256:5643a4e1b729803e67ddceee450e87052527b37cac394bf900b4f8e3d1bb3e9b

🤖 I have created a release *beep* *boop* --- ### [1.2.11](googleapis/java-iam@v1.2.10...v1.2.11) (2022-03-25) ### Dependencies * update dependency com.google.api:api-common to v2.1.5 ([#313](googleapis/java-iam#313)) ([08a700e](googleapis/java-iam@08a700e)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).

ajkannan added the api: cloudresourcemanager Issues related to the Resource Manager API. label Nov 2, 2015

ajkannan assigned aozarov Nov 2, 2015

googlebot added the cla: yes This human has signed the Contributor License Agreement. label Nov 2, 2015

ajkannan unassigned aozarov Nov 2, 2015

aozarov reviewed Nov 2, 2015
View reviewed changes

Create packages for resource manager and outline spi layer.

e3ca489

ajkannan force-pushed the resource-manager branch from d240f95 to e3ca489 Compare November 3, 2015 01:01

aozarov reviewed Nov 3, 2015
View reviewed changes

gcloud-java-resourcemanager/src/main/java/com/google/gcloud/spi/ResourceManagerRpc.java

Tuple<String, Iterable<Project>> list() throws ResourceManagerException;

Tuple<String, Iterable<Project>> list(String filter) throws ResourceManagerException;

This comment was marked as spam.

Sign in to view

Fixes to the ResourceManagerRpc layer, and also add resource manager …

57df7ac

…to pom files spi api fixes

ajkannan force-pushed the resource-manager branch from dcd9534 to 51f5311 Compare November 3, 2015 16:41

minor changes to ResourceManagerRpc

10904d9

ajkannan force-pushed the resource-manager branch from 51f5311 to 10904d9 Compare November 3, 2015 16:43

aozarov reviewed Nov 3, 2015
View reviewed changes

gcloud-java-resourcemanager/src/main/java/com/google/gcloud/spi/ResourceManagerRpc.java

LIST,

UPDATE,

GET_IAM_POLICY,

SET_IAM_POLICY;

This comment was marked as spam.

Sign in to view

Style updates to ResourceManagerRpc

766716f

add return values to delete, undelete, and setIamPolicy

0f292cb

ajkannan force-pushed the resource-manager branch from 5a3dfb4 to 0f292cb Compare November 3, 2015 21:52

aozarov reviewed Nov 4, 2015
View reviewed changes

gcloud-java-resourcemanager/src/main/java/com/google/gcloud/spi/ResourceManagerRpc.java

public enum SetIamPolicyResult {

SUCCESS,

ETAG_NOT_MATCH

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

aozarov reviewed Nov 4, 2015
View reviewed changes

Remove spi result enums, change 'update/set' terminology to 'replace'

247550f

aozarov added a commit that referenced this pull request Nov 4, 2015

Merge pull request #314 from ajkannan/resource-manager

cfe1633

Create packages for resource manager and outline spi layer.

aozarov merged commit cfe1633 into googleapis:resource-manager Nov 4, 2015

ajkannan deleted the resource-manager branch November 10, 2015 21:35

github-actions bot pushed a commit to suztomo/google-cloud-java that referenced this pull request Jun 29, 2022

chore(deps): update dependency com.google.cloud:libraries-bom to v16 (g…

ebe5330

…oogleapis#314)

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Create packages for resource manager and outline spi layer. #314

Create packages for resource manager and outline spi layer. #314

ajkannan commented Nov 2, 2015

This comment was marked as spam.

This comment was marked as spam.

aozarov commented Nov 3, 2015

ajkannan commented Nov 3, 2015

ajkannan commented Nov 3, 2015

This comment was marked as spam.

ajkannan commented Nov 3, 2015

ajkannan commented Nov 3, 2015

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

aozarov commented Nov 4, 2015

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

ajkannan commented Nov 4, 2015


		Tuple<String, Iterable<Project>> list() throws ResourceManagerException;

		Tuple<String, Iterable<Project>> list(String filter) throws ResourceManagerException;


		Project update(Project project) throws ResourceManagerException;

		Policy getIamPolicy(String projectId) throws ResourceManagerException;

Create packages for resource manager and outline spi layer. #314

Create packages for resource manager and outline spi layer. #314

Conversation

ajkannan commented Nov 2, 2015

This comment was marked as spam.

This comment was marked as spam.

aozarov commented Nov 3, 2015

ajkannan commented Nov 3, 2015

ajkannan commented Nov 3, 2015

This comment was marked as spam.

ajkannan commented Nov 3, 2015

ajkannan commented Nov 3, 2015

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

aozarov commented Nov 4, 2015

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

ajkannan commented Nov 4, 2015