Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(internal/kokoro): Update vet.sh staticcheck #5876

Merged
merged 2 commits into from
Apr 11, 2022
Merged

chore(internal/kokoro): Update vet.sh staticcheck #5876

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f632912
chore(internal/kokoro): Update vet.sh staticcheck
quartzmo Apr 8, 2022
0c61edd
Merge branch 'main' into staticcheck
codyoss Apr 11, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion cmd/go-cloud-debug-agent/internal/controller/client.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -96,7 +96,7 @@ var newService = func(ctx context.Context, tokenSource oauth2.TokenSource) (serv
if err != nil {
return nil, err
}
s, err := cd.New(httpClient)
s, err := cd.NewService(ctx, option.WithHTTPClient(httpClient))
if err != nil {
return nil, err
}
Expand Down
8 changes: 4 additions & 4 deletions cmd/go-cloud-debug-agent/internal/controller/client_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -174,7 +174,7 @@ func TestDebugletControllerClientLibrary(t *testing.T) {
if err := validateLabels(c, opts); err != nil {
t.Fatalf("Invalid labels:\n%v", err)
}
if list, err = c.List(ctx); err != nil {
if _, err = c.List(ctx); err != nil {
t.Fatal("List:", err)
}
if m.registerCallsSeen != 1 {
Expand All @@ -189,21 +189,21 @@ func TestDebugletControllerClientLibrary(t *testing.T) {
if err = c.Update(ctx, list.Breakpoints[0].Id, &cd.Breakpoint{Id: testBreakpointID, IsFinalState: true}); err != nil {
t.Fatal("Update:", err)
}
if list, err = c.List(ctx); err != nil {
if _, err = c.List(ctx); err != nil {
t.Fatal("List:", err)
}
if m.registerCallsSeen != 1 {
t.Errorf("saw %d Register calls, want 1", m.registerCallsSeen)
}
// The next List call produces an error that should cause a Register call.
if list, err = c.List(ctx); err == nil {
if _, err = c.List(ctx); err == nil {
t.Fatal("List should have returned an error")
}
if m.registerCallsSeen != 2 {
t.Errorf("saw %d Register calls, want 2", m.registerCallsSeen)
}
// The next List call produces an error that should not cause a Register call.
if list, err = c.List(ctx); err == nil {
if _, err = c.List(ctx); err == nil {
t.Fatal("List should have returned an error")
}
if m.registerCallsSeen != 2 {
Expand Down
Loading